Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Enable logging macros in downstream projects #2357

Open
tfeher opened this issue Jun 10, 2024 · 0 comments
Open

[BUG] Enable logging macros in downstream projects #2357

tfeher opened this issue Jun 10, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tfeher
Copy link
Contributor

tfeher commented Jun 10, 2024

Describe the bug
The raft logging macros rely on RAFT_NAME static variable to get the logger.

RAFT_NAME is defined in the raft namespace, but the macros use the variable without specifying the namespace.

This leads to an error if the logger is used in a dowstream project, like cuvs. Currently the following workaround is used:

https://github.com/rapidsai/cuvs/blob/863b8bdd4ef25537d453157eae2dd2bcf8e69786/cpp/src/cluster/detail/kmeans.cuh#L60

Expected behavior
Logging works without adding extra definition for RAFT_NAME.

@tfeher tfeher added the bug Something isn't working label Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant