We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The raft logging macros rely on RAFT_NAME static variable to get the logger.
RAFT_NAME
RAFT_NAME is defined in the raft namespace, but the macros use the variable without specifying the namespace.
raft
This leads to an error if the logger is used in a dowstream project, like cuvs. Currently the following workaround is used:
cuvs
https://github.com/rapidsai/cuvs/blob/863b8bdd4ef25537d453157eae2dd2bcf8e69786/cpp/src/cluster/detail/kmeans.cuh#L60
Expected behavior Logging works without adding extra definition for RAFT_NAME.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Describe the bug
The raft logging macros rely on
RAFT_NAME
static variable to get the logger.RAFT_NAME
is defined in theraft
namespace, but the macros use the variable without specifying the namespace.This leads to an error if the logger is used in a dowstream project, like
cuvs
. Currently the following workaround is used:https://github.com/rapidsai/cuvs/blob/863b8bdd4ef25537d453157eae2dd2bcf8e69786/cpp/src/cluster/detail/kmeans.cuh#L60
Expected behavior
Logging works without adding extra definition for
RAFT_NAME
.The text was updated successfully, but these errors were encountered: