Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Expose algorithm selection in matrix.select_k python API #2427

Open
mirzadeh opened this issue Sep 4, 2024 · 0 comments
Open

[FEA] Expose algorithm selection in matrix.select_k python API #2427

mirzadeh opened this issue Sep 4, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@mirzadeh
Copy link

mirzadeh commented Sep 4, 2024

Is your feature request related to a problem? Please describe.
The current python API (here) in pylibraft.matrix.select_k does not expose the algorithm selection that the C++ API does, see here. Instead it uses the default value which automatically selects the algorithm.

Describe the solution you'd like
I'd suggest passing an extra enum argument to the function that allows selecting the algorithm similar to the C++ API.

Describe alternatives you've considered
In a benchmark, the default automatic algorithm performs poorly (~10X slower) than the AIR-TopK reported in this paper. Using the C++ API, I can reproduce the same timings reported in the paper when choosing raft::matrix::SelectAlgo::kRadix11bits algorithm.

Additional context
C++ documentation is provided here.

@mirzadeh mirzadeh added the feature request New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant