RATESWSX-310: prevent bidirectionality if manual deliver/return/cance…

…l has been processed

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## WIP
 
+* RATESWSX-310: prevent bidirectionality if manual deliver/return/cancel has been processed
+
 ## Version 7.0.1 - Released on 2024-06-07
 
 RATESWSX-303: fix admin-session logout endless redirect & make admin-session urls more unified

src/Components/StateMachine/Subscriber/AbstractOrderStatusSubscriber.php

@@ -94,6 +94,10 @@ public function onItemsOperationDone(OrderItemOperationDoneEvent $event): void
             $canceledItemQty += $position->getCanceled();
         }
 
+        $event->getContext()->addArrayExtension('ratepay', [
+            TransitionSubscriber::PREVENT_BIDIRECTIONALITY => true,
+        ]);
+
         try {
             if ($fullCanceled && $canceledItemQty > 0) {
                 $this->onFullCancel($event);
@@ -108,6 +112,8 @@ public function onItemsOperationDone(OrderItemOperationDoneEvent $event): void
             }
         } catch (IllegalTransitionException) {
             // do nothing.
+        } finally {
+            $event->getContext()->removeExtension('ratepay');
         }
     }
 

src/Components/StateMachine/Subscriber/TransitionSubscriber.php

@@ -34,6 +34,8 @@
 
 class TransitionSubscriber implements EventSubscriberInterface
 {
+    public const PREVENT_BIDIRECTIONALITY = 'prevent_bidirectionality';
+
     public function __construct(
         private readonly EntityRepository $orderDeliveryRepository,
         private readonly EntityRepository $orderRepository,
@@ -58,6 +60,12 @@ public function onTransition(StateMachineTransitionEvent $event): void
             return;
         }
 
+        /** @var ArrayStruct|null $struct */
+        $struct = $event->getContext()->getExtension('ratepay');
+        if ($struct?->get(self::PREVENT_BIDIRECTIONALITY) === true) {
+            return;
+        }
+
         /** @var OrderDeliveryEntity $orderDelivery */
         $orderDelivery = $this->orderDeliveryRepository->search(new Criteria([$event->getEntityId()]), $event->getContext())->first();
         /** @var OrderEntity $order */