Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): update structure in get template method #62

Merged
merged 7 commits into from
Apr 26, 2022

Conversation

ChrisCindy
Copy link
Contributor

@ChrisCindy ChrisCindy commented Apr 24, 2022

  • change data structure of the return value in get template method
  • use handler to distinguish events and on props
  • set @pwc/compiler type to cjs temporarily (switch to esm after finishing accessing ice/pkg)

Rongyan Chen and others added 2 commits April 21, 2022 02:02
* feat: support svg elements

* chore: fix lint and add notes
@ChrisCindy ChrisCindy linked an issue Apr 24, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

❗ No coverage uploaded for pull request base (refactor/runtime-structure@b38fee5). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 17cd9ba differs from pull request most recent head 9674e1c. Consider uploading reports for the commit 9674e1c to get more accurate results

@@                      Coverage Diff                      @@
##             refactor/runtime-structure      #62   +/-   ##
=============================================================
  Coverage                              ?   85.21%           
=============================================================
  Files                                 ?       41           
  Lines                                 ?      805           
  Branches                              ?      186           
=============================================================
  Hits                                  ?      686           
  Misses                                ?      119           
  Partials                              ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38fee5...9674e1c. Read the comment docs.

@ChrisCindy ChrisCindy changed the base branch from main to refactor/runtime-structure April 25, 2022 02:14
@SoloJiang SoloJiang merged commit 9c687a5 into refactor/runtime-structure Apr 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat/template-structure branch April 26, 2022 06:34
SoloJiang added a commit that referenced this pull request May 11, 2022
* refactor: runtime structure

* chore: lint

* feat: support element template diff

* chore: lint

* feat(compiler): update structure in get template method (#62)

* feat: support svg elements (#60)

* feat: support svg elements

* chore: fix lint and add notes

* feat(compiler): update structure in get template method

* fix(compiler): lint error

* feat(compiler): use handler to distinguish events and on props

* chore(compiler): add EventAttributeDescriptor interface

Co-authored-by: Rongyan Chen <chenrongyan.cry@alibaba-inc.com>
Co-authored-by: 狒狒神 <fushen.jzw@alibaba-inc.com>

* feat: html method support new structure

* feat: html method support new structure

* fix(compiler): inject wrong value in runtime compiler

* refactor: reactive node

* chore: test case

* fix(compiler): replace values with templateData in template result

* chore: test case

* chore: add test case

* refactor: base render

* chore: revert code

* chore: test case

* chore: lint

* chore: ts type

* chore: test case

* chore: add comment

* chore: remove useless comment

* chore: add test case

* chore: optimize code

* chore: optimize code

* chore: link

* chore: optimize code

Co-authored-by: NK <yxy0919@foxmail.com>
Co-authored-by: Rongyan Chen <chenrongyan.cry@alibaba-inc.com>
Co-authored-by: 逆葵 <xianyong.yxy@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhance] 修改事件字符并增加模板标识
4 participants