Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K2 Support - Add FirDeclarationGenerationExtension as replacement for SyntheticResolveExtension #1483

Closed
cmelchior opened this issue Aug 14, 2023 · 0 comments · Fixed by #1525
Assignees

Comments

@cmelchior
Copy link
Contributor

cmelchior commented Aug 14, 2023

See this Kotlin Slack conversation https://kotlinlang.slack.com/archives/C7L3JB43G/p1691477003733109

But basically, we need to replace our current SyntheticResolveExtension with a similar FirDeclarationGenerationExtension implementation.

With #1476 being merged soon, hopefully, that is the only change that needs to happen.
We still need to rely on ComponentRegistrar rather than CompilerPluginRegistrar due to the issue described here: https://youtrack.jetbrains.com/issue/KT-55300/Provide-a-mechanism-to-describe-ordering-and-dependencies-for-compiler-plugins

See e.g. the all-opens plugin for a strategy on how to create a plugin that supports both: https://github.com/JetBrains/kotlin/tree/master/plugins/allopen

@rorbech rorbech mentioned this issue Sep 26, 2023
4 tasks
@rorbech rorbech self-assigned this Oct 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants