Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up and improve Kafka integration tests #368

Open
Jeffail opened this issue Feb 4, 2020 · 3 comments
Open

Fix up and improve Kafka integration tests #368

Jeffail opened this issue Feb 4, 2020 · 3 comments
Labels
help wanted inputs Any tasks or issues relating specifically to inputs outputs Any tasks or issues relating specifically to outputs

Comments

@Jeffail
Copy link
Collaborator

Jeffail commented Feb 4, 2020

The integration tests (https://github.com/Jeffail/benthos/tree/master/lib/test/integration) for Kafka are awful, mostly because Kafka is an utter pain to run. They need to be updated and fixed up, ideally so that they also run on macOS (with docker running in a VM) and with settings for SASL and ideally TLS being tested also.

@Jeffail Jeffail added help wanted inputs Any tasks or issues relating specifically to inputs outputs Any tasks or issues relating specifically to outputs labels Feb 4, 2020
@mangatmodi
Copy link

How about using TestContainers? I have been using Kafka's TestContainer in Mac and it is working well.

@jarri-abidi
Copy link

Where exactly are the integration tests for kafka @Jeffail? The link in the description returns 404.

@Jeffail
Copy link
Collaborator Author

Jeffail commented Jun 22, 2022

Hey @jarri-abidi they're within https://github.com/benthosdev/benthos/tree/main/internal/impl/kafka now, since raising this issue I've introduced tests around Redpanda which work much better but ideally I'd still like to have tests against an official Kafka container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted inputs Any tasks or issues relating specifically to inputs outputs Any tasks or issues relating specifically to outputs
Projects
None yet
Development

No branches or pull requests

3 participants