Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal #163

Open
7 of 11 tasks
Frenkiee opened this issue Feb 3, 2022 · 1 comment
Open
7 of 11 tasks

Proposal #163

Frenkiee opened this issue Feb 3, 2022 · 1 comment

Comments

@Frenkiee
Copy link
Collaborator

Frenkiee commented Feb 3, 2022

For the following tasks, we suggest the following implementations:

  • Checksum all EVM addresses (now they are retrieved as lowercased)
  • Pool tracking table
  • EVM Event table for both verified and unverified EVM events
  • Track ReefswapFactory PairCreated event, create a new contract for newly created Pair and verify contract
  • Track ReefswapPair events: Mint (add liquidity), Burn (remove liquidity), Swap (on swap), Sync (called after every event)
  • Crawler backtracking of unverified EVM events (once a new verified contract is detected, go through its old unverified events and verify them)
  • NFT and NFTs page
  • FE navigation bar - group Contracts, Tokens, and NFTs under Contracts dropdown
  • FE navigation bar - group Blocks, Extrinsics, Events under Blocks dropdown
  • Style dropdown
  • Pool and Pools page?

Pool DB schematic:

  • token address 1 (foreign key on contract)
  • token address 2 (foreign key on contract)
  • pool address (foreign key on contract)
  • fee
  • volume
  • block id?
  • decimals
  • timestamp
  • current price
  • token amount 1
  • token amount 2
  • tvl (total value locked)
  • reserve amount for token 1
  • reserve amount for token 2
  • event type (Mint, Burn, Swap)
@Netherdrake
Copy link
Member

Netherdrake commented Feb 8, 2022

I think leaving addresses as lowercase in database is fine. From usability perspective, this is more convenient, because every language including SQL has a string.to_lower_case() type of function, while the reverse is not true (need special library to generate checksum addresses).

The checksum addresses are mostly to be used in UI's to prevent some class of copy/paste errors (all addresses in Reefscan UI should be ckecksum cased)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants