From 9f16fb896be578c4fb7ab4046e0dfe9ed44a513e Mon Sep 17 00:00:00 2001
From: Nek-12 <vaizin.nikita@gmail.com>
Date: Tue, 12 Dec 2023 12:18:21 +0300
Subject: [PATCH] update build configuration

---
 .idea/inspectionProfiles/Project_Default.xml  |  3 +
 .../inspectionProfiles/profiles_settings.xml  |  7 ++
 build.gradle.kts                              | 25 +++---
 buildSrc/src/main/kotlin/Config.kt            |  4 +-
 buildSrc/src/main/kotlin/ConfigureAndroid.kt  | 15 ++--
 .../src/main/kotlin/ConfigureMultiplatform.kt | 87 +++++++++++--------
 .../pro.respawn.android-library.gradle.kts    |  1 -
 .../pro.respawn.shared-library.gradle.kts     |  1 -
 gradle.properties                             |  3 -
 settings.gradle.kts                           | 22 +++--
 10 files changed, 97 insertions(+), 71 deletions(-)
 create mode 100644 .idea/inspectionProfiles/profiles_settings.xml

diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
index 2d5f4f0..0d67c80 100644
--- a/.idea/inspectionProfiles/Project_Default.xml
+++ b/.idea/inspectionProfiles/Project_Default.xml
@@ -3,6 +3,9 @@
     <option name="myName" value="Project Default" />
     <inspection_tool class="AnimateAsStateLabel" enabled="false" level="WARNING" enabled_by_default="false" />
     <inspection_tool class="AnimatedContentLabel" enabled="false" level="WARNING" enabled_by_default="false" />
+    <inspection_tool class="ConstPropertyName" enabled="true" level="WEAK WARNING" enabled_by_default="true">
+      <option name="namePattern" value="[A-Za-z][_A-Z\d]*" />
+    </inspection_tool>
     <inspection_tool class="CrossfadeLabel" enabled="false" level="WARNING" enabled_by_default="false" />
     <inspection_tool class="InfinitePropertiesLabel" enabled="false" level="WARNING" enabled_by_default="false" />
     <inspection_tool class="InfiniteTransitionLabel" enabled="false" level="WARNING" enabled_by_default="false" />
diff --git a/.idea/inspectionProfiles/profiles_settings.xml b/.idea/inspectionProfiles/profiles_settings.xml
new file mode 100644
index 0000000..dd4c951
--- /dev/null
+++ b/.idea/inspectionProfiles/profiles_settings.xml
@@ -0,0 +1,7 @@
+<component name="InspectionProjectProfileManager">
+  <settings>
+    <option name="PROJECT_PROFILE" value="Default" />
+    <option name="USE_PROJECT_PROFILE" value="false" />
+    <version value="1.0" />
+  </settings>
+</component>
\ No newline at end of file
diff --git a/build.gradle.kts b/build.gradle.kts
index 5bce343..45cd495 100644
--- a/build.gradle.kts
+++ b/build.gradle.kts
@@ -1,3 +1,5 @@
+import com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask
+import nl.littlerobots.vcu.plugin.versionCatalogUpdate
 import org.jetbrains.kotlin.gradle.targets.js.yarn.YarnLockMismatchReport
 import org.jetbrains.kotlin.gradle.targets.js.yarn.YarnRootExtension
 import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
@@ -9,15 +11,10 @@ plugins {
     alias(libs.plugins.version.catalog.update)
     alias(libs.plugins.dokka)
     alias(libs.plugins.dependencyAnalysis)
-}
-
-buildscript {
-    dependencies {
-        classpath(libs.android.gradle)
-        classpath(libs.kotlin.gradle)
-        classpath(libs.version.gradle)
-        classpath(libs.detekt.gradle)
-    }
+    // plugins already on a classpath (conventions)
+    // alias(libs.plugins.androidApplication) apply false
+    // alias(libs.plugins.androidLibrary) apply false
+    // alias(libs.plugins.kotlinMultiplatform) apply false
 }
 
 allprojects {
@@ -27,7 +24,7 @@ allprojects {
         compilerOptions {
             jvmTarget.set(Config.jvmTarget)
             languageVersion.set(Config.kotlinVersion)
-            freeCompilerArgs.addAll(Config.compilerArgs)
+            freeCompilerArgs.apply { addAll(Config.jvmCompilerArgs) }
             optIn.addAll(Config.optIns.map { "-opt-in=$it" })
         }
     }
@@ -65,10 +62,8 @@ doctor {
 }
 
 dependencyAnalysis {
-    issues {
-        all {
-            ignoreKtx(true)
-        }
+    structure {
+        ignoreKtx(true)
     }
 }
 
@@ -124,7 +119,7 @@ tasks {
         autoCorrect = false
     }
 
-    withType<com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask>().configureEach {
+    withType<DependencyUpdatesTask>().configureEach {
         outputFormatter = "json"
 
         fun stabilityLevel(version: String): Int {
diff --git a/buildSrc/src/main/kotlin/Config.kt b/buildSrc/src/main/kotlin/Config.kt
index 5ceebac..757ef6c 100644
--- a/buildSrc/src/main/kotlin/Config.kt
+++ b/buildSrc/src/main/kotlin/Config.kt
@@ -45,6 +45,7 @@ feature-rich.
         addAll(compilerArgs)
         add("-Xjvm-default=all") // enable all jvm optimizations
         add("-Xcontext-receivers")
+        add("-Xstring-concat=inline")
         addAll(optIns.map { "-opt-in=$it" })
     }
 
@@ -52,8 +53,8 @@ feature-rich.
     val javaVersion = JavaVersion.VERSION_11
     val kotlinVersion = org.jetbrains.kotlin.gradle.dsl.KotlinVersion.KOTLIN_1_9
     const val compileSdk = 34
-    const val minSdk = 21
     const val targetSdk = compileSdk
+    const val minSdk = 21
     const val appMinSdk = 26
     const val publishingVariant = "release"
 
@@ -67,7 +68,6 @@ feature-rich.
     const val consumerProguardFile = "consumer-rules.pro"
 
     val stabilityLevels = listOf("preview", "eap", "alpha", "beta", "m", "cr", "rc")
-
     object Detekt {
 
         const val configFile = "detekt.yml"
diff --git a/buildSrc/src/main/kotlin/ConfigureAndroid.kt b/buildSrc/src/main/kotlin/ConfigureAndroid.kt
index 1850be4..1dfd4a7 100644
--- a/buildSrc/src/main/kotlin/ConfigureAndroid.kt
+++ b/buildSrc/src/main/kotlin/ConfigureAndroid.kt
@@ -8,6 +8,8 @@ fun Project.configureAndroid(
     commonExtension: CommonExtension<*, *, *, *, *, *>,
 ) = commonExtension.apply {
     compileSdk = Config.compileSdk
+    val libs by versionCatalog
+
     defaultConfig {
         minSdk = Config.minSdk
         testInstrumentationRunner = Config.testRunner
@@ -44,12 +46,11 @@ fun Project.configureAndroid(
     }
 
     packaging {
-        resources {
-            excludes += setOf(
-                "DebugProbesKt.bin",
-                "/META-INF/{AL2.0,LGPL2.1}",
-            )
-        }
+        resources.excludes += listOf(
+            "/META-INF/{AL2.0,LGPL2.1}",
+            "DebugProbesKt.bin",
+            "META-INF/versions/9/previous-compilation-data.bin"
+        )
     }
 
     testOptions {
@@ -65,7 +66,7 @@ fun Project.configureAndroid(
             }
         }
     }
-    val libs by versionCatalog
+
     composeOptions {
         kotlinCompilerExtensionVersion = libs.requireVersion("compose-compiler")
         useLiveLiterals = true
diff --git a/buildSrc/src/main/kotlin/ConfigureMultiplatform.kt b/buildSrc/src/main/kotlin/ConfigureMultiplatform.kt
index 857e208..a5a336d 100644
--- a/buildSrc/src/main/kotlin/ConfigureMultiplatform.kt
+++ b/buildSrc/src/main/kotlin/ConfigureMultiplatform.kt
@@ -7,49 +7,66 @@ import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
 
 fun Project.configureMultiplatform(
     ext: KotlinMultiplatformExtension,
+    jvm: Boolean = true,
+    android: Boolean = true,
+    linux: Boolean = true,
+    iOs: Boolean = true,
+    js: Boolean = true,
+    tvOs: Boolean = true,
+    macOs: Boolean = true,
+    watchOs: Boolean = true
 ) = ext.apply {
     val libs by versionCatalog
     explicitApi()
-
     applyDefaultHierarchyTemplate()
+    withSourcesJar(true)
 
-    linuxX64()
-    linuxArm64()
-    mingwX64()
-
-    js(IR) {
-        browser()
-        nodejs()
-        binaries.library()
+    if (linux) {
+        linuxX64()
+        linuxArm64()
+        mingwX64()
     }
 
-    androidTarget {
-        publishLibraryVariants("release")
+    if (js) {
+        js(IR) {
+            browser()
+            nodejs()
+            binaries.library()
+        }
     }
 
-    jvm {
-        compilations.all {
-            kotlinOptions {
-                jvmTarget = Config.jvmTarget.target
-                freeCompilerArgs += Config.jvmCompilerArgs
-            }
+    if (android) {
+        androidTarget {
+            publishAllLibraryVariants()
         }
     }
 
-    listOf(
-        iosX64(),
-        iosArm64(),
-        iosSimulatorArm64(),
-        macosArm64(),
-        macosX64(),
-        tvosX64(),
-        tvosArm64(),
-        tvosSimulatorArm64(),
-        watchosX64(),
-        watchosArm64(),
-        watchosDeviceArm64(),
-        watchosSimulatorArm64(),
-    ).forEach {
+    if (jvm) {
+        jvm()
+    }
+
+    sequence {
+        if (iOs) {
+            yield(iosX64())
+            yield(iosArm64())
+            yield(iosSimulatorArm64())
+        }
+        if (macOs) {
+            yield(macosArm64())
+            yield(macosX64())
+        }
+        if (tvOs) {
+            yield(tvosX64())
+            yield(tvosArm64())
+            yield(tvosSimulatorArm64())
+        }
+        if (watchOs) {
+            yield(watchosX64())
+            yield(watchosArm64())
+            yield(watchosDeviceArm64())
+            yield(watchosSimulatorArm64())
+        }
+    }.forEach {
         it.binaries.framework {
             binaryOption("bundleId", Config.artifactId)
             binaryOption("bundleVersion", Config.versionName)
@@ -58,9 +75,11 @@ fun Project.configureMultiplatform(
     }
 
     sourceSets.apply {
-        val jvmTest by getting {
-            dependencies {
-                implementation(libs.requireLib("kotest-junit"))
+        if (jvm) {
+            val jvmTest by getting {
+                dependencies {
+                    implementation(libs.requireLib("kotest-junit"))
+                }
             }
         }
         all {
diff --git a/buildSrc/src/main/kotlin/pro.respawn.android-library.gradle.kts b/buildSrc/src/main/kotlin/pro.respawn.android-library.gradle.kts
index a8b64d8..7d34e31 100644
--- a/buildSrc/src/main/kotlin/pro.respawn.android-library.gradle.kts
+++ b/buildSrc/src/main/kotlin/pro.respawn.android-library.gradle.kts
@@ -14,7 +14,6 @@ android {
     publishAndroid(this)
 
     kotlinOptions {
-        freeCompilerArgs += Config.jvmCompilerArgs
         jvmTarget = Config.jvmTarget.target
         languageVersion = Config.kotlinVersion.version
     }
diff --git a/buildSrc/src/main/kotlin/pro.respawn.shared-library.gradle.kts b/buildSrc/src/main/kotlin/pro.respawn.shared-library.gradle.kts
index 108329a..d467e51 100644
--- a/buildSrc/src/main/kotlin/pro.respawn.shared-library.gradle.kts
+++ b/buildSrc/src/main/kotlin/pro.respawn.shared-library.gradle.kts
@@ -2,7 +2,6 @@ import org.gradle.kotlin.dsl.kotlin
 import org.gradle.kotlin.dsl.signing
 
 plugins {
-    // id(libs.plugins.atomicfu.id)
     kotlin("multiplatform")
     id("com.android.library")
     id("maven-publish")
diff --git a/gradle.properties b/gradle.properties
index 9e9a9a9..5843e65 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -18,6 +18,3 @@ android.disableResourceValidation=true
 android.nonFinalResIds=true
 kotlin.mpp.androidGradlePluginCompatibility.nowarn=true
 kotlin.native.ignoreIncorrectDependencies=true
-# TODO: Set to true after https://github.com/Kotlin/kotlinx-atomicfu/issues/250
-kotlinx.atomicfu.enableJvmIrTransformation=false
-systemProp.org.gradle.unsafe.kotlin.assignment=true
diff --git a/settings.gradle.kts b/settings.gradle.kts
index d237681..076ca76 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -1,18 +1,24 @@
+enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS")
+
 pluginManagement {
     repositories {
         google()
         gradlePluginPortal()
         mavenCentral()
+        maven("https://maven.pkg.jetbrains.space/public/p/compose/dev")
     }
-}
 
-enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS")
-
-buildscript {
-    repositories {
-        google()
-        gradlePluginPortal()
-        mavenCentral()
+    // TODO: https://github.com/Kotlin/kotlinx-atomicfu/issues/56
+    resolutionStrategy {
+        eachPlugin {
+            val module = when (requested.id.id) {
+                "kotlinx-atomicfu" -> "org.jetbrains.kotlinx:atomicfu-gradle-plugin:${requested.version}"
+                else -> null
+            }
+            if (module != null) {
+                useModule(module)
+            }
+        }
     }
 }