Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A11y review: Table #64

Open
hobbes7878 opened this issue Apr 14, 2023 · 4 comments
Open

A11y review: Table #64

hobbes7878 opened this issue Apr 14, 2023 · 4 comments
Assignees
Labels

Comments

@hobbes7878
Copy link
Member

Hey @juruwolfe, Welsh added a new component would be good to get the a11y team to audit at their leisure:
https://reuters-graphics.github.io/graphics-components/?path=/docs/components-table--default

Anyone in that group I can pin this ticket to?

@juruwolfe
Copy link

Oh yeah I can take a look once I'm back

@juruwolfe
Copy link

Thank you for flagging!

@hobbes7878
Copy link
Member Author

hobbes7878 commented Apr 14, 2023

All yours. Thanks mucho. cc @palewire

@palewire
Copy link
Contributor

palewire commented Apr 14, 2023

Very nice. If I can help, let me know.

Two things on my mind:

  • Since we broke the metadata out of the <caption> tag, should we consider an aria-describedby attribute that links the table to the header, as described in "Approach 2" here.
  • Should we scope the rows by default by making the first cell a <th scole="row">, as shown here? I've never known if that's something that ought to be universal, or only when the first cell signifies something unique about the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants