From cb73023e357d168dad093c66ecc183676d855196 Mon Sep 17 00:00:00 2001 From: Robert Haschke Date: Fri, 2 Feb 2024 08:13:23 +0100 Subject: [PATCH] CI: Build against Qt 6 --- .github/workflows/Dockerfile | 4 ++++ .github/workflows/ci.yaml | 7 ++++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/Dockerfile b/.github/workflows/Dockerfile index 5097b1c46..707a412a4 100644 --- a/.github/workflows/Dockerfile +++ b/.github/workflows/Dockerfile @@ -24,6 +24,10 @@ RUN --mount=type=bind,target=/tmp/rviz \ # Preferred build tools clang clang-format-12 clang-tidy clang-tools ccache && \ # + if "$ROS_DISTRO" == "one"; then \ + apt-get install --no-install-recommends -y qt6-base-dev qt6-base-dev-tools; \ + fi && \ + # # Download all dependencies for rviz rosdep update $(test "${ROS_DISTRO}" = "melodic" && echo "--include-eol-distros") && \ DEBIAN_FRONTEND=noninteractive \ diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index b649be74f..18285d20b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -15,17 +15,22 @@ jobs: matrix: distro: [noetic, jammy] ogre: ["1.9", "1.12"] + qt: [5] include: - distro: noetic ogre: 1.9 env: CLANG_TIDY: true + - distro: jammy + ogre: 1.12 + qt: 6 env: CXXFLAGS: "-DRVIZ_DEPRECATE_QT4_SLOTS -Werror -Wall -Wextra -Wwrite-strings -Wunreachable-code -Wpointer-arith -Wredundant-decls -Wno-strict-aliasing -Wno-sign-compare" UPSTREAM_WORKSPACE: ${{ matrix.distro != 'jammy' && 'github:rhaschke/python_qt_binding#silent-external-warnings' || '' }} AFTER_INSTALL_TARGET_DEPENDENCIES: apt install -qq -y libogre-${{ matrix.ogre }}-dev CATKIN_LINT: true + CMAKE_ARGS: -DRVIZ_QT_VERSIONS="${{ matrix.qt }}" CCACHE_DIR: ${{ github.workspace }}/.ccache BASEDIR: /home/runner/work DOCKER_IMAGE: rhaschke/ici:rviz-${{ matrix.distro }}-ros @@ -33,7 +38,7 @@ jobs: # perform full clang-tidy check only on manual trigger (workflow_dispatch), PRs do check changed files, otherwise nothing CLANG_TIDY_BASE_REF: ${{ github.event_name != 'workflow_dispatch' && (github.base_ref || github.ref) || '' }} - name: "${{ matrix.distro }} • ogre ${{ matrix.ogre }}${{ matrix.env.CLANG_TIDY && (github.event_name != 'workflow_dispatch' && ' • clang-tidy (delta)' || ' • clang-tidy (all)') || '' }}" + name: "${{ matrix.distro }} • ogre ${{ matrix.ogre }} • Qt ${{ matrix.qt }}${{ matrix.env.CLANG_TIDY && (github.event_name != 'workflow_dispatch' && ' • clang-tidy (delta)' || ' • clang-tidy (all)') || '' }}" runs-on: ubuntu-latest steps: - uses: actions/checkout@v3