Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running word_freqs throws ValueError for all submissions #53

Open
dotnwat opened this issue Aug 26, 2016 · 6 comments
Open

running word_freqs throws ValueError for all submissions #53

dotnwat opened this issue Aug 26, 2016 · 6 comments
Labels

Comments

@dotnwat
Copy link

dotnwat commented Aug 26, 2016

I'm having some trouble running word_freqs. When I run the tool each submission is skipped due to ValueError, and the output files are empty. Example:

(env) MacBook-Air:reddit-analysis john$ word_freqs -l 1 -p day johndoe /r/news
Analyzing /r/news
.
Skipping submission https://www.reddit.com/r/news/comments/4zkn83/itt_tech_banned_from_enrolling_new_students_who/ due to ValueError.
@rhiever rhiever added the bug label Aug 26, 2016
@rhiever
Copy link
Owner

rhiever commented Aug 26, 2016

Darn. Maybe Reddit changed their API and that's messing up the script. I've filed this as a probable bug, but I probably won't find time to look into this anytime soon. Add a comment here if you're interested in digging into this bug.

cc @bboe

@dotnwat
Copy link
Author

dotnwat commented Aug 26, 2016

I can dig into it it a bit. What I'm seeing is that in parse_text an exception is being thrown when BeautifulSoup object is created.

The input that I printed out was

I just sold all my things and bought a one way ticket to the other side of the world. I consider 
myself opting out; engaged withdrawal. Experimenting with shedding the ways in which I've 
been conditioned by my culture and my comforts. I'll be camping down the coast by myself for 
the next few weeks before catching a flight with nothing but the pack on my back. I have very 
few solid plans, just trust. It's thrilling and extremely uncomfortable.

And looks like the exception that is thrown is <class 'bs4.FeatureNotFound'>

@bboe
Copy link
Contributor

bboe commented Aug 26, 2016

@rhiever I don't have any insight to add from Reddit's API side. Perhaps there is a new bs4 version that is backwards incompatible?

@mikeygeeman
Copy link

Try changing findAll to find_all

I think that changed somewhere

@bboe
Copy link
Contributor

bboe commented Apr 22, 2018

Also this one, is it still an issue?

@rhiever
Copy link
Owner

rhiever commented Apr 23, 2018

Never got around to digging into this one to see if it is indeed a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants