Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getLogoUrl #211

Closed
gcandal opened this issue Nov 10, 2020 · 0 comments
Closed

getLogoUrl #211

gcandal opened this issue Nov 10, 2020 · 0 comments
Assignees
@BeeMargarida
Labels
enhancement New feature or request

Comments

@gcandal
Copy link
Contributor

gcandal commented Nov 10, 2020

Description

Create getLogo, getLogoP and getLogoUrl functions (similarly to getMeshX) that will rely on RIPE Core's /api/brands/<str:brand>/logo.<str:format>.
@gcandal gcandal added the enhancement New feature or request label Nov 10, 2020
@BeeMargarida BeeMargarida mentioned this issue Nov 11, 2020
Merged
joamag added a commit that referenced this issue Nov 11, 2020
@joamag
Merge pull request #212 from ripe-tech/ms/211-get_logo_methods
781c588 
#211: getLogo and getLogoP methods
@gcandal gcandal closed this as completed Nov 11, 2020
@ripe-tobias-bot ripe-tobias-bot bot mentioned this issue Oct 18, 2021
Merged
joamag added a commit that referenced this issue Oct 25, 2021
@joamag
Merge pull request #319 from ripe-tech/ns/209-fix_price
e6c88ea 
#211 Fix `price` in `importOrderP()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BeeMargarida BeeMargarida

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gcandal @BeeMargarida