Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spec.json Tag to deactivate mask #307

Closed
dsafonso opened this issue Aug 31, 2021 · 6 comments
Closed

Spec.json Tag to deactivate mask #307

dsafonso opened this issue Aug 31, 2021 · 6 comments
Assignees
@dsafonso
Labels
enhancement New feature or request feature-request 💡 Request the addition of a feature p-medium Medium priority issue

Comments

@dsafonso
Copy link

Rationale

Now we have an option on SDK to deactivate the masks and should be nice have a tag to be add in the model spec to deactivate it.

Description

Should be possible add a tag example "no_mask" and when this model is on white the masks are deactivated by default.
example:
image
image
@dsafonso dsafonso added the enhancement New feature or request label Aug 31, 2021
@ripe-tobias-bot ripe-tobias-bot bot added the triage Issue currently under triage label Aug 31, 2021
@ripe-tobias-bot

This comment has been minimized.

Sign in to view
@dsafonso dsafonso added the feature-request 💡 Request the addition of a feature label Aug 31, 2021
@joamag joamag removed the triage Issue currently under triage label Sep 1, 2021
@joamag joamag assigned gcandal and unassigned joamag Sep 1, 2021
@joamag
Copy link
Contributor

joamag commented Sep 1, 2021

@gcandal Let's do this it should be pretty easy (or not as the config does not exist since the beginning)
@gcandal please explore ideas

@joamag joamag added the p-medium Medium priority issue label Sep 1, 2021
@gcandal gcandal assigned BeeMargarida and unassigned gcandal Sep 2, 2021
@BeeMargarida BeeMargarida mentioned this issue Sep 2, 2021
Merged
@joamag joamag changed the title Tag for deactivate mask Spec.json Tag to deactivate mask Sep 3, 2021
joamag added a commit that referenced this issue Sep 6, 2021
@joamag
Merge pull request #308 from ripe-tech/ms/307-no_masks_tag
130a949 
#307: Disable masks if build contains "no_masks" tag
@gcandal gcandal assigned dsafonso and unassigned BeeMargarida Sep 7, 2021
@dsafonso
Copy link
Author

@gcandal Is missing deployment of SDK to test this

@dsafonso dsafonso assigned gcandal and unassigned dsafonso Sep 13, 2021
@dsafonso
Copy link
Author

@BeeMargarida Missing update the documentation with this new tag: https://dev.platforme.com/p/specs/build.md

@BeeMargarida
Copy link
Contributor

BeeMargarida commented Sep 13, 2021 •
edited
Loading

@BeeMargarida Missing update the documentation with this new tag: https://dev.platforme.com/p/specs/build.md

On it 🏃‍♀️ !

This was referenced Sep 22, 2021
Merged
Merged
@gcandal gcandal assigned dsafonso and unassigned gcandal Sep 28, 2021
@dsafonso
Copy link
Author

Test with brand cariuma model oca_low OK 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsafonso dsafonso

Labels
enhancement New feature or request feature-request 💡 Request the addition of a feature p-medium Medium priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joamag @gcandal @dsafonso @BeeMargarida