Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK slow response when doing setInitialsExtra #357

Closed
3rdvision opened this issue Feb 18, 2022 · 7 comments
Closed

SDK slow response when doing setInitialsExtra #357

3rdvision opened this issue Feb 18, 2022 · 7 comments
Assignees
Labels
bug Something isn't working fast-track Feature to be fixed or implemented ASAP p-high High priority issue ysl Issue is related to the Yves Saint Laurent client
Milestone

Comments

@3rdvision
Copy link
Contributor

3rdvision commented Feb 18, 2022

Description

SDK takes too long to update images when calling for several setInitialsExtra.

In practice ripe-white takes much longer - more than 2x the amount of time - than RIPE API to render an image after user initials requests.

I believe this has to do with SDK's implementation to cancel old requests - it's not working as expected.

Please watch the videos below.

Expected vs. Observed

- -
Expected The image should render what it's typed on white right away, not the first character and then the whole word.
Observed The observed state at the end of the repro steps.

Repro Steps

  1. Open ripe-white https://ripe-white-now.platforme.com/?context=saint_laurent_hoodie
  2. Write something in initials input with more than 1 character like "1234"
  3. Watch the image first render an image with the first character "1" and only then "1234" no matter how fast it's typed

Videos

From RIPE White

Peek.2022-02-18.11-27.mp4

From YSL's Website

2022-02-14_15h20_05.mp4
@3rdvision 3rdvision added the bug Something isn't working label Feb 18, 2022
@ripe-tobias-bot ripe-tobias-bot bot added the triage Issue currently under triage label Feb 18, 2022
@ripe-tobias-bot

This comment was marked as resolved.

@3rdvision
Copy link
Contributor Author

This can be solved by implementing a debouncer when doing setInitialsExtra.

Now this debouncer could be implemented at SDK level and enabled/disabled with a certain timer by default or we just don't implement it and instead pass that responsibility to whoever uses the SDK.

@joamag I'd say this is a point of discussion in tech decision.

@joamag
Copy link
Contributor

joamag commented Feb 25, 2022

discussion

Yes, let's implement it at the SDK level. On top of that let's cancel previous requests when new ones arise if needed.

@3rdvision
Copy link
Contributor Author

On top of that let's canceled previous requests when new ones arise, if needed.

That one is already implemented

Ok, going ahead with the debouncer implementation at SDK level for the setInitialsExtra.

@joamag joamag added fast-track Feature to be fixed or implemented ASAP p-high High priority issue and removed triage Issue currently under triage labels Mar 3, 2022
@joamag joamag assigned 3rdvision and unassigned joamag Mar 3, 2022
@joamag joamag added the ysl Issue is related to the Yves Saint Laurent client label Mar 3, 2022
@msp-platforme msp-platforme added this to the Sprint 1 milestone Mar 14, 2022
@luisamd
Copy link

luisamd commented Mar 22, 2022

@3rdvision Is this story ready for QA? If so, please update the Kanban board 😄

@3rdvision
Copy link
Contributor Author

@msp-platforme
Copy link

We no longer see the first character being rendered first, and then rendering the rest of the inserted characters.
In that regard, the expectation is met.
Speed performance still is not ideal, @3rdvision will see what else can be done.

Ysl-rendering.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fast-track Feature to be fixed or implemented ASAP p-high High priority issue ysl Issue is related to the Yves Saint Laurent client
Projects
None yet
Development

No branches or pull requests

4 participants