-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK slow response when doing setInitialsExtra #357
Comments
This comment was marked as resolved.
This comment was marked as resolved.
This can be solved by implementing a debouncer when doing Now this debouncer could be implemented at SDK level and enabled/disabled with a certain timer by default or we just don't implement it and instead pass that responsibility to whoever uses the SDK. @joamag I'd say this is a point of discussion in tech decision. |
Yes, let's implement it at the SDK level. On top of that let's cancel previous requests when new ones arise if needed. |
That one is already implemented Ok, going ahead with the debouncer implementation at SDK level for the |
@3rdvision Is this story ready for QA? If so, please update the Kanban board 😄 |
@msp-platforme Deployed and ready to test at https://ripe-white-now.platforme.com/?context=saint_laurent_hoodie |
We no longer see the first character being rendered first, and then rendering the rest of the inserted characters. Ysl-rendering.mp4 |
Description
SDK takes too long to update images when calling for several
setInitialsExtra
.In practice ripe-white takes much longer - more than 2x the amount of time - than RIPE API to render an image after user initials requests.
I believe this has to do with SDK's implementation to cancel old requests - it's not working as expected.
Please watch the videos below.
Expected vs. Observed
Repro Steps
Videos
From RIPE White
Peek.2022-02-18.11-27.mp4
From YSL's Website
2022-02-14_15h20_05.mp4
The text was updated successfully, but these errors were encountered: