Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve textures parameterization #477

Closed
NFSS10 opened this issue Feb 14, 2023 · 0 comments
Closed

Improve textures parameterization #477

NFSS10 opened this issue Feb 14, 2023 · 0 comments
Assignees
Labels
CSR enhancement New feature or request

Comments

@NFSS10
Copy link
Contributor

NFSS10 commented Feb 14, 2023

Rationale

Applying textures to the CSR initials is a painful and long process as in some instances there can be up to 5 different texture types just to have the visual result expected. This means that when a user wants to tweak the textures, they need to make the change in all 5 textures, upload them, make a build, deploy it and just then it's possible to visualize the result.This makes things like fine tuning extremely hard and requires the user to know how to use image editing tools when there is no need to.

There are ways to greatly improve this, one of which is supporting the parameterization of the textutes. Doing this allows the user to just specify the texture properties and the rendering will be done respecting those rules. There are no cons and the benefits would be for faster iteration on the creation of builds and allowing the fine tunning of the CSR initials via the spec.

Description

Support texture parametrization. This should be a feature that can be optionally used and the user should be able to set those properties via the config.

Implementation

Add support in CSR initials logic to load and apply textures properties and ripe-docs with documentation about the new properties supported in the config.

References

https://threejs.org/docs/#api/en/textures/Texture

@NFSS10 NFSS10 self-assigned this Feb 14, 2023
@NFSS10 NFSS10 added CSR enhancement New feature or request labels Feb 14, 2023
@NFSS10 NFSS10 closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSR enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant