-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency errors do not show title
or ui:title
#4402
Comments
@chibacchie does your fix in #4398 also fix this issue? |
@heath-freenome I did not fix this issue in #4398. To fix this issue, we may:
|
@chibacchie The probability of AJV making that change is lower than fixing our code. Is that something that you are willing to attempt? |
…:title. This fix only applicable if we use an ajv-i18n localizer. Ref. rjsf-team#4402.
…:title. This fix only applicable if we use an ajv-i18n localizer. Ref. rjsf-team#4402.
@heath-freenome Indeed. I made a PR which is only applicable if we use an ajv-18n localizer (See #4417). For the case without localizer, I plan to submit a PR for ajv as I don't have any idea to fix this issue without changing ajv. |
I agree, we should do our best to request consistency from ajv. |
Prerequisites
What theme are you using?
validator-ajv8
Version
5.23.1
Current Behavior
Dependency errors do not show
title
orui:title
.This results in
must have property billingAddress when property creditCard is present
.Expected Behavior
must have property 'Billing address' when property 'Credit card' is present
is expected.There are two possible causes:
ajv
does not enclose raw property names with quotes (see here) while transformRJSFValidationErrors() expects property names are enclosed.transformRJSFValidationErrors()
only handlesmissingProperty
(see this block).property
anddeps
should be handled as well.Steps To Reproduce
Please see above.
Environment
Anything else?
No response
The text was updated successfully, but these errors were encountered: