Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bundle @types/json-schema in the generated d.ts types of RJSF #4420

Open
1 task done
Elessar1802 opened this issue Dec 18, 2024 · 0 comments
Open
1 task done
Labels
feature Is a feature request needs triage Initial label given, to be assigned correct labels and assigned

Comments

@Elessar1802
Copy link

Prerequisites

What theme are you using?

utils

Is your feature request related to a problem? Please describe.

If I try to use StrictRJSFForm type from @rjsf/utils, we don't get JSONSchema7 type since "@types/json-schema": "^7.0.15" is a dev-dependency.

Took me some time to realise this issue. As a quick fix for my app I just added the "@types/json-schema" as a dev-dependency. But this will break as soon as RJSF moves to a new json schema format.

Describe the solution you'd like

While I understand @types/json-schema should be a dev-dependency but wouldn't it be better if this type is bundled with the generated types? Or maybe add this as a special box to documents if no such change is made to the code?

Describe alternatives you've considered

No response

@Elessar1802 Elessar1802 added feature Is a feature request needs triage Initial label given, to be assigned correct labels and assigned labels Dec 18, 2024
@Elessar1802 Elessar1802 changed the title chore: chore: bundle @types/json-schema in the generated d.ts types of RJSF Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is a feature request needs triage Initial label given, to be assigned correct labels and assigned
Projects
None yet
Development

No branches or pull requests

1 participant