Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeypointsDataset] - create a new dataset format to load keypoints #1438

Open
SkalskiP opened this issue Aug 8, 2024 · 4 comments
Open

[KeypointsDataset] - create a new dataset format to load keypoints #1438

SkalskiP opened this issue Aug 8, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@SkalskiP
Copy link
Collaborator

SkalskiP commented Aug 8, 2024

Description

Supervision can currently load object detection, instance segmentation, and classification datasets. Let's add the ability to handle keypoint datasets. The sv.KeypointDataset should offer the same functionalities as sv.DetectionDataset and sv.ClassificationDataset, including merge, split, __getitem__, __iter__, from_yolo, and as_yolo.

Additional

  • Note: Please share a Google Colab with minimal code to test the new feature. We know it's additional work, but it will speed up the review process. The reviewer must test each change. Setting up a local environment to do this is time-consuming. Please ensure that Google Colab can be accessed without any issues (make it public). Thank you! 🙏🏻
@SkalskiP SkalskiP added the enhancement New feature or request label Aug 8, 2024
@shaddu
Copy link
Contributor

shaddu commented Aug 12, 2024

Hi @SkalskiP 👋

I was analyzing the issue and understood that KeypointsDataset will be similar to DetectionDataset, with the difference being the type of annotations.

classes: List[str],
images: Union[List[str], Dict[str, np.ndarray]],
annotations: Dict[str, KeyPoints]

If this is a correct understanding then I will like to work on this issue.

@LinasKo
Copy link
Contributor

LinasKo commented Aug 13, 2024

Let's only implement the new, lazy-loaded, non-deprecated API, with images: List[str]. This will save work in the future.

@LinasKo
Copy link
Contributor

LinasKo commented Aug 13, 2024

@shaddu, I also made this template, which should help with starting your colab: Colab Template.
Feel free to use as much or as little of it as you wish 😉

@shaddu
Copy link
Contributor

shaddu commented Aug 13, 2024

Hi @LinasKo 👋

I also noticed the deprecated warning in the Datasets classes, and the clarification around images: List[str] is helpful.

Thank you for sharing the Colab template 😎 . It will be helpful, and I will suggest adding some similar Colab templates to the contribution guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants