Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordered Chooser #118

Open
msoucy opened this issue Feb 21, 2017 · 3 comments
Open

Ordered Chooser #118

msoucy opened this issue Feb 21, 2017 · 3 comments

Comments

@msoucy
Copy link
Contributor

msoucy commented Feb 21, 2017

For feature parity with wpilibsuite/allwpilib#492, the chooser should be ordered.

See wpilibsuite/allwpilib#491 for rationale

@ThadHouse
Copy link
Member

This is going to be a much harder fix in C#, since we don't have an equivalent in the .NET framework. I don't think C++ does either. In addition, I think we were actually looking at reworking sendable choosers for 2018, so we'll see. Most likely that PR won't get merged this season anyway.

@msoucy
Copy link
Contributor Author

msoucy commented Feb 25, 2017

Slight nitpick - .NET does have an OrderedDictionary, though it does seem outdated. Does this planned rework remove the disparity with the Java WPILib, where sendables in .NET aren't templated?

@ThadHouse
Copy link
Member

Yeah that ordered dictionary isn't even generic. So definitely no to that. They never created a generic one.
TBH I had totally forgotten we made them generic in Java. That's not directly the reason for the rewrite however. We were looking at it to update some bugs that would be hard to remove from the current implementation. This hasn't been decided yet however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants