Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib bundling not working on debian #528

Open
GuillaumeFromage opened this issue Jun 24, 2024 · 1 comment
Open

zlib bundling not working on debian #528

GuillaumeFromage opened this issue Jun 24, 2024 · 1 comment

Comments

@GuillaumeFromage
Copy link

GuillaumeFromage commented Jun 24, 2024

Hi there,

Is there a more portable way of ensuring that zlib is bundled with
I'm getting errors from that line

self.copy_file(zlib.__file__, os.path.dirname(arcdir))
as on debian zlib is built-in with python (as of debian 12/bookworm). I could make a pull request, but I don't see quite an obvious way of ensuring zlib is present on the mac where the app will be deployed.

More background: according to this stack overflow post from 12 years ago: https://stackoverflow.com/questions/269795/how-do-i-find-the-location-of-python-module-sources/13888157#13888157 ; __file__ isn't the best way. Using inspect, as the post suggested lead me to discover that zlib is often built-in with python: https://askubuntu.com/questions/741609/install-python-package-locally/741614#741614 .

Cheers

@tusharsadhwani
Copy link

Simply commenting out those lines worked for me:

        # if sys.version_info[0] != 2:
        #     import zlib

        #     self.copy_file(zlib.__file__, os.path.dirname(arcdir))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants