Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rooki calls cancel method despite request completing successfully #143

Open
JamesVarndell opened this issue Mar 16, 2021 · 4 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@JamesVarndell
Copy link

@cehbrecht sometimes rooki attempts to call a cancel method in the middle of a workflow running - even when that request eventually succeeds on the server side. Here's the traceback we're getting from rooki:

  File "/home/cds/cdsservices/services/esgf_wps/requests.py", line 60, in process
    response = workflow.orchestrate()
  File "/usr/local/lib/python3.6/site-packages/rooki/operators.py", line 33, in orchestrate
    return rooki.orchestrate(workflow=self._serialise())
  File "</usr/local/lib/python3.6/site-packages/birdy/client/base.py-2>", line 5, in orchestrate
  File "/usr/local/lib/python3.6/site-packages/rooki/client.py", line 49, in _execute
    resp = super(Rooki, self)._execute(pid, **kwargs)
  File "/usr/local/lib/python3.6/site-packages/birdy/client/base.py", line 354, in _execute
    self._console_monitor(wps_response)
  File "/usr/local/lib/python3.6/site-packages/birdy/client/base.py", line 387, in _console_monitor
    execution.checkStatus(sleepSecs=sleep)
  File "/usr/local/lib64/python3.6/site-packages/owslib/wps.py", line 829, in checkStatus
    sleep(sleepSecs)
  File "/usr/local/lib/python3.6/site-packages/birdy/client/base.py", line 382, in sigint_handler
    self.cancel()
AttributeError: 'Rooki' object has no attribute 'cancel'
'}
@cehbrecht cehbrecht self-assigned this Mar 16, 2021
@cehbrecht cehbrecht added the bug Something isn't working label Mar 16, 2021
@cehbrecht
Copy link
Collaborator

@JamesVarndell do you also have the rooki request for me?

@cehbrecht
Copy link
Collaborator

cehbrecht commented Mar 16, 2021

Strange thing :) The cancel method is only available when the notebook widgets are enabled (need to patch this in birdy). But I don't understand where signal comes from. It doesn`t look like a timeout as I first thought.

I can quick-fix it in rooki ... but need to have a proper fix in birdy.

@cehbrecht
Copy link
Collaborator

@JamesVarndell workaround added:
roocs/rooki#57

@cehbrecht
Copy link
Collaborator

Opened and issue in birdy:
bird-house/birdy#192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants