New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create User try catch on the service layer. #676

Open

EMazzaglia opened this issue Aug 19, 2021 · 0 comments

Assignees

Contributor

EMazzaglia commented Aug 19, 2021

  @Post()
  async post(@Body() userDTO: SignUpDTO): Promise<InsertResult> {
    try {
      return await this.usersService.createUser(
        EntityMapper.mapTo(User, userDTO)
      );
    } catch (error: any) {
      throw new BadRequestError(
        error.detail ?? error.message ?? ErrorsMessages.INTERNAL_SERVER_ERROR
      );
    }
  }

This shouldnt have the try catch and delegate the responsability to the service.

EMazzaglia self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment