From aa294ae40167d03db208f2acccfb50608e62d207 Mon Sep 17 00:00:00 2001 From: Jan Pikora Date: Tue, 12 Sep 2023 13:16:04 +0200 Subject: [PATCH 1/3] sonarcloud bug complain fix --- tests/04_00_02-fedchange.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/04_00_02-fedchange.js b/tests/04_00_02-fedchange.js index 418f202..ffcdd69 100644 --- a/tests/04_00_02-fedchange.js +++ b/tests/04_00_02-fedchange.js @@ -281,14 +281,14 @@ describe('RSK Federation change', function() { await checkFederationAddedNewKeys(); var addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); expect(Number(addResult)).to.equal(-10); // not a public key - - await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( + + const addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( newFederationPublicKeys[0][KEY_TYPE_BTC], newFederationPublicKeys[0][KEY_TYPE_RSK], newFederationPublicKeys[0][KEY_TYPE_MST] - ).call({ from: getRandomFedChangeAddress() }), (addResult => { - expect(Number(addResult)).to.equal(-2); // already in there - }); + ).call({ from: getRandomFedChangeAddress() }); + + expect(Number(addResult)).to.equal(-2); var sz = await rskClientOldFed.rsk.bridge.methods.getPendingFederationSize().call(); expect(Number(sz)).to.equal(newFederationPublicKeys.length); // success From 3e7e52a7ac83a3b3034263e434975e3ad9e050a6 Mon Sep 17 00:00:00 2001 From: Jan Pikora Date: Tue, 12 Sep 2023 13:45:54 +0200 Subject: [PATCH 2/3] renaming const --- tests/04_00_02-fedchange.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/04_00_02-fedchange.js b/tests/04_00_02-fedchange.js index ffcdd69..489eecd 100644 --- a/tests/04_00_02-fedchange.js +++ b/tests/04_00_02-fedchange.js @@ -279,16 +279,16 @@ describe('RSK Federation change', function() { } await checkFederationAddedNewKeys(); - var addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); - expect(Number(addResult)).to.equal(-10); // not a public key + var addKeysResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); + expect(Number(addKeysResult)).to.equal(-10); // not a public key - const addResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( + const addPublicKeysResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey( newFederationPublicKeys[0][KEY_TYPE_BTC], newFederationPublicKeys[0][KEY_TYPE_RSK], newFederationPublicKeys[0][KEY_TYPE_MST] ).call({ from: getRandomFedChangeAddress() }); - expect(Number(addResult)).to.equal(-2); + expect(Number(addPublicKeysResult)).to.equal(-2); var sz = await rskClientOldFed.rsk.bridge.methods.getPendingFederationSize().call(); expect(Number(sz)).to.equal(newFederationPublicKeys.length); // success From 89cda18e0d8b0b8625733bbf3782c48a7d77bc69 Mon Sep 17 00:00:00 2001 From: Marcos Irisarri <53787863+marcos-iov@users.noreply.github.com> Date: Wed, 13 Sep 2023 14:29:28 -0300 Subject: [PATCH 3/3] Change variable declaration from var to const --- tests/04_00_02-fedchange.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/04_00_02-fedchange.js b/tests/04_00_02-fedchange.js index 489eecd..9188a80 100644 --- a/tests/04_00_02-fedchange.js +++ b/tests/04_00_02-fedchange.js @@ -279,7 +279,7 @@ describe('RSK Federation change', function() { } await checkFederationAddedNewKeys(); - var addKeysResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); + const addKeysResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey('0xaabb', '0xccdd', '0xeeff').call({ from: getRandomFedChangeAddress() }); expect(Number(addKeysResult)).to.equal(-10); // not a public key const addPublicKeysResult = await rskClientOldFed.rsk.bridge.methods.addFederatorPublicKeyMultikey(