Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

olsrr 0.60 - olsrr::ols_step_all_possible function displays the incorrect values under "Mallow's Cp" #215

Open
LSantanaZA opened this issue Oct 29, 2024 · 1 comment

Comments

@LSantanaZA
Copy link

Hi,

I encountered an issue with the standard output of "olsrr::ols_step_all_possible" in version 0.6.0.

The last column is labelled "Mallow's Cp" but appears to actually print the values for the predicted R-square.

This can be seen using the example code provided by the function's help file:

model <- lm(mpg ~ disp + hp, data = mtcars)
k <- ols_step_all_possible(model)

# output created by default (note the values of Mallow's Cp)
k
#  Index N Predictors  R-Square Adj. R-Square Mallow's Cp
#1     1 1       disp 0.7183433     0.7089548   0.6751205
#2     2 1         hp 0.6024373     0.5891853   0.5096958
#3     3 2    disp hp 0.7482402     0.7308774   0.6945438

# Entire "result" output (note the values of "predrsq" and "cp" compared to the output above)
k$result
# mindex n predictors   rsquare      adjr     rmse   predrsq        cp      aic     sbic      sbc     msep
# 1      1 1       disp 0.7183433 0.7089548 3.148207 0.6751205  4.443792 170.2094 79.34223 174.6066 338.3482
# 2      2 1         hp 0.6024373 0.5891853 3.740297 0.5096958 17.794906 181.2386 89.04015 185.6358 477.5836
# 3      3 2    disp hp 0.7482402 0.7308774 2.976436 0.6945438  3.000000 168.6186 78.40578 174.4815 313.2349
# fpe       apc       hsp
# 1 11.23270 0.3192109 0.3645502
# 2 15.85513 0.4505710 0.5145682
# 3 10.69210 0.3038481 0.3491298
@aravindhebbali
Copy link
Member

Hi,

Thanks for bringing this to our attention. This issue was fixed in #211 but is yet to be published on CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants