New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Changes not yet saved!" in Lyrics View without changing anything #52

Open

rstemmer opened this issue Jan 23, 2021 · 1 comment

Labels

🐞 Bug 🎭 Cannot Reproduce 🐒 Front-End ☃️ Low Priority

Owner

rstemmer commented Jan 23, 2021 •

edited

Loading

There is an issue in the lyrics view that leads to a misleading warning.
When showing lyrics, the message "Changes not yet saved!" is shown, even when the lyrics have not been edited by the user.

This message is kind of correct because there are actually differences between the lyrics received from the server and the lyrics handled by the viewer.
The viewer removed some invalid/useless characters (like windows-syle line breaks) which leads to differences recognized by the Lyrics Viewer so that this message gets shown.

This message box can be ignored as long es the Lyrics Viewer is not in edit mode.
When it is in edit mode, it is save to save the lyrics to get a clean data set.
I recommend to actually switch to edit mode and save the clean version of the lyrics.

MusicDB Version: 7.0.0-beta2

rstemmer added 🐞 Bug ☃️ Low Priority labels

Owner Author

rstemmer commented Sep 17, 2021

It seems that the Show/Hide state of the messages are not reset when new lyrics get loaded.

Edit lyrics of one song
Leave without saving
Open editor for lyrics of another song
Message still visible. Should be hidden.

rstemmer added 🎭 Cannot Reproduce 🐒 Front-End labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment