Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linter rule to avoid shadowing builtins #302

Open
nathanjmcdougall opened this issue Aug 20, 2024 · 0 comments · May be fixed by #303
Open

Enable linter rule to avoid shadowing builtins #302

nathanjmcdougall opened this issue Aug 20, 2024 · 0 comments · May be fixed by #303

Comments

@nathanjmcdougall
Copy link
Contributor

In #274, I inadvertently shadowed the builtin type in my PR, which was caught in review.

It might be good to enable these ruff rules (category A from flake8-builtins):
https://docs.astral.sh/ruff/rules/#flake8-builtins-a
e.g.
https://docs.astral.sh/ruff/rules/builtin-variable-shadowing/

This would help automatically avoid this situation in the future.
@nathanjmcdougall nathanjmcdougall linked a pull request Aug 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid shadowing builtins nathanjmcdougall/pins-python
1 participant
@nathanjmcdougall