You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks, I agree reticulate should support results = 'hide' option.
What is the relation or difference between include = FALSE and results = 'hide'?
I believe that reticulate already has support for a include = FALSE chunk option.
include = FALSE means that chunks are ran, but nothing (nor source or results) is added to the output. This is directly handled by knitr for all engine as it will only show the processed output of an engine when include = TRUE.
results = "hide" means to hide the results in the outputs. echo = FALSE and results = "hide" together are almost equivalent to include = FALSE, except with includes, all the hooks will still apply (especially the output hooks). While for results is does not necessarily. But usually the hooks may not do any difference.
Anyhow, I don't think reticulate needs to handle include, but it needs to handle results. I'll send a PR.
Reported in
and full example at
Problem
Currently,
results = 'hide'
does not seem to be handled by reticulate's knitr engine. Example:The results will still be shown. This is a minimal example - see posit-dev/great-tables#291 for one with great_tables
Context
This is because
_repr_html_
is catched to be returned as aknitr::raw_html()
reticulate/R/knitr-engine.R
Lines 744 to 750 in d4e752b
and provided in the
out
component on whichknitr:::sew()
will applyreticulate/R/knitr-engine.R
Lines 626 to 628 in d4e752b
By returning
engine_output(out = )
, knitr's assumes the output is already filtered with what should be filtered.Otherwise, it will be handled directly
engine_output()
default usagehttps://github.com/yihui/knitr/blob/ba8d9fb0ecd60f3f9ebec58fdde1e689bdc40ad3/R/engine.R#L96-L98
So I do think reticulate needs to support
results = 'hide'
and not provide outputs in the list when the option is provided.I can make a PR - just need to think about the best place to do this.
The text was updated successfully, but these errors were encountered: