From 632dd9ac7ff64ae544e41eaec98b21eeb65b6785 Mon Sep 17 00:00:00 2001 From: isabelizimm Date: Fri, 27 Oct 2023 12:56:21 -0400 Subject: [PATCH 1/4] bump min rsconnect to 1.21.0 --- setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.cfg b/setup.cfg index 62cd44f..34c9eb1 100644 --- a/setup.cfg +++ b/setup.cfg @@ -31,7 +31,7 @@ install_requires = nest-asyncio requests pins>=0.7.1 - rsconnect-python>=1.8.0 + rsconnect-python>=1.21.0 plotly pip-tools httpx From a27e8d0775b8fcec9dca915a6f0e61e3f859c884 Mon Sep 17 00:00:00 2001 From: isabelizimm Date: Fri, 27 Oct 2023 13:06:14 -0400 Subject: [PATCH 2/4] print out requirements.txt in test --- .github/workflows/tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 2c59f4b..aa4cec2 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -63,6 +63,7 @@ jobs: docker-compose up --build -d pip freeze > requirements.txt make dev + cat requirements.txt env: RSC_LICENSE: ${{ secrets.RSC_LICENSE }} GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} From 217e8c6f3b35a9f8366d99c8de6196b2806da26a Mon Sep 17 00:00:00 2001 From: isabelizimm Date: Fri, 27 Oct 2023 13:33:19 -0400 Subject: [PATCH 3/4] conda_mode is not supported, but still a required arg --- vetiver/rsconnect.py | 1 + 1 file changed, 1 insertion(+) diff --git a/vetiver/rsconnect.py b/vetiver/rsconnect.py index fc2d597..7c410d2 100644 --- a/vetiver/rsconnect.py +++ b/vetiver/rsconnect.py @@ -108,6 +108,7 @@ def deploy_rsconnect( app_id=app_id, title=title, python=python, + conda_mode=False, force_generate=force_generate, log_callback=log_callback, image=image, From 069deadfe2c8e5103819888bccaf2fb85bc7e617 Mon Sep 17 00:00:00 2001 From: isabelizimm Date: Fri, 27 Oct 2023 14:00:38 -0400 Subject: [PATCH 4/4] not as breaking as we imagined --- setup.cfg | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.cfg b/setup.cfg index 34c9eb1..ef3a541 100644 --- a/setup.cfg +++ b/setup.cfg @@ -31,7 +31,7 @@ install_requires = nest-asyncio requests pins>=0.7.1 - rsconnect-python>=1.21.0 + rsconnect-python>=1.11.0 plotly pip-tools httpx