From b1963e7b72554c9672900ba046c3088598955488 Mon Sep 17 00:00:00 2001
From: Nony Dutton <nony.dutton@zendesk.com>
Date: Thu, 4 Apr 2024 20:11:45 +0200
Subject: [PATCH] Use default `max_lines` when calling `up` & `down`

Both `up` and `down` only show 1 source line when called, I think it
would be more useful if they provided more context. This removes the
`max_lines: 1` kwarg when they call `show_src`. `max_lines` in `show_src` will default
to `CONFIG[:show_src_lines]`[^1].

[^1]:(https://github.com/ruby/debug/blob/0b77e8294b5b220b3b2a089bf09f94808654899a/lib/debug/thread_client.rb#L510)
---
 lib/debug/thread_client.rb  |  4 +-
 test/console/config_test.rb | 74 ++++++++++++++++++++++++++++---------
 2 files changed, 58 insertions(+), 20 deletions(-)

diff --git a/lib/debug/thread_client.rb b/lib/debug/thread_client.rb
index 80a434b0c..91251c9b2 100644
--- a/lib/debug/thread_client.rb
+++ b/lib/debug/thread_client.rb
@@ -1079,13 +1079,13 @@ def wait_next_action_
           when :up
             if @current_frame_index + 1 < @target_frames.size
               @current_frame_index += 1
-              show_src max_lines: 1
+              show_src
               show_frame(@current_frame_index)
             end
           when :down
             if @current_frame_index > 0
               @current_frame_index -= 1
-              show_src max_lines: 1
+              show_src
               show_frame(@current_frame_index)
             end
           when :set
diff --git a/test/console/config_test.rb b/test/console/config_test.rb
index 589be7488..53881c3e2 100644
--- a/test/console/config_test.rb
+++ b/test/console/config_test.rb
@@ -72,21 +72,28 @@ def test_config_show_frames_set
   class ShowSrcLinesTest < ConsoleTestCase
     def program
       <<~RUBY
-      1| p 1
-      2| p 2
-      3| p 3
-      4| p 4
-      5| p 5
-      6| p 6
-      7| p 7
-      8| p 8
-      9| p 9
-      10| binding.b
-      11| p 11
-      12| p 12
-      13| p 13
-      14| p 14
-      15| p 15
+      1| class Foo
+      2|   def self.a
+      3|     p 1
+      4|     p 2
+      5|     p 3
+      6|     p 3
+      7|     p 5
+      8|     p 6
+      9|     p 7
+     10|     p 8
+     11|     p 9
+     12|     p 10
+     13|     b
+     14|   end
+     15|
+     16|   def self.b
+     17|     binding.b
+     18|     p 11
+     19|   end
+     20| end
+     21|
+     22| Foo.a
       RUBY
     end
 
@@ -95,11 +102,42 @@ def test_show_src_lines_control_the_lines_displayed_on_breakpoint
         type 'config set show_src_lines 2'
         type 'continue'
         assert_line_text([
-          /9| p 9/,
-          /=>   10| binding.b/
+          /16\|   def self\.b/,
+          /=>  17\|     binding\.b/
         ])
+        assert_no_line_text(/15\|/)
+        assert_no_line_text(/18\|/)
+        type 'continue'
+      end
+    end
 
-        assert_no_line_text(/p 11/)
+    def test_show_src_lines_control_the_lines_displayed_on_up
+      debug_code(program) do
+        type 'config set show_src_lines 2'
+        type 'continue'
+        type 'up'
+        assert_line_text([
+          /12\|     p 10/,
+          /=>  13\|     b/,
+        ])
+        assert_no_line_text(/11\|/)
+        assert_no_line_text(/14\|/)
+        type 'continue'
+      end
+    end
+
+    def test_show_src_lines_control_the_lines_displayed_on_down
+      debug_code(program) do
+        type 'config set show_src_lines 2'
+        type 'continue'
+        type 'up'
+        type 'down'
+        assert_line_text([
+          /16\|   def self\.b/,
+          /=>  17\|     binding\.b/
+        ])
+        assert_no_line_text(/15\|/)
+        assert_no_line_text(/18\|/)
         type 'continue'
       end
     end