fix: Fix GitHub pull request mergeability for rerun checks #5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajax-ryzhyi-r
requested review from
chenrui333,
lukemassa and
nitrocode
and removed request for
a team
ajax-ryzhyi-r
changed the title
ajax-ryzhyi-r
force-pushed
the
github-mergeability-fix
branch
from
325dda2 to
a71df4d
Compare
github-actions
bot
added
build
ajax-ryzhyi-r
force-pushed
the
github-mergeability-fix
branch
2 times, most recently
from
53ae7d2 to
325dda2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
This PR modifies the evaluation logic for statusContexts and checkRuns by iterating from the end of the arrays instead of the beginning.
why
There is an issue described in detail in #5048 where Atlantis still treats a PR as unmergeable after successfully rerunning failed required checks. It responds with the error
Apply Failed: Pull request must be mergeable before running apply.when attempting to use theatlantis applycommand.Upon investigating this issue, I discovered that GitHub returns all statusContexts/checkRuns in chronological order when Atlantis retrieves a pull request's last commit mergeability status. However, Atlantis iterates through these statusContexts/checkRuns and retrieves the first statusContext/checkRun instead of the last one, which represents the current status.
tests
references
Fixes #5048