From 4ba30e66d9c0135a49e1e976422e4e9663de2adc Mon Sep 17 00:00:00 2001 From: "Tobin C. Harding" Date: Wed, 31 Jul 2024 15:02:56 -0500 Subject: [PATCH] Remove a few casts In an effort to be more readable use `usize::from` instead of a cast. There are a few casts left but this all the ones that can use `From`. Refactor only, no logic changes. Close #181 --- src/primitives/gf32.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/primitives/gf32.rs b/src/primitives/gf32.rs index 511a51252..c4fe07024 100644 --- a/src/primitives/gf32.rs +++ b/src/primitives/gf32.rs @@ -270,8 +270,8 @@ impl super::Field for Fe32 { if self.0 == 0 || other.0 == 0 { Fe32(0) } else { - let log1 = LOG[self.0 as usize]; - let log2 = LOG[other.0 as usize]; + let log1 = LOG[usize::from(self.0)]; + let log2 = LOG[usize::from(other.0)]; let mult_order = Self::MULTIPLICATIVE_ORDER as isize; Fe32(LOG_INV[((log1 + log2) % mult_order) as usize]) } @@ -282,8 +282,8 @@ impl super::Field for Fe32 { } else if other.0 == 0 { panic!("Attempt to divide {} by 0 in GF32", self); } else { - let log1 = LOG[self.0 as usize]; - let log2 = LOG[other.0 as usize]; + let log1 = LOG[usize::from(self.0)]; + let log2 = LOG[usize::from(other.0)]; let mult_order = Self::MULTIPLICATIVE_ORDER as isize; Fe32(LOG_INV[((mult_order + log1 - log2) % mult_order) as usize]) }