Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riscv: align assembly functions with cortex-m crate #181

Closed
romancardenas opened this issue Feb 14, 2024 · 1 comment · Fixed by #246
Closed

riscv: align assembly functions with cortex-m crate #181

romancardenas opened this issue Feb 14, 2024 · 1 comment · Fixed by #246
Milestone

Comments

@romancardenas
Copy link
Contributor

romancardenas commented Feb 14, 2024

Motivated by #179 (and #180), I took a look on how the cortex-m crate deals with assembly instructions, and most of them are safe and use options to avoid the compiler from using the stack etc.

@rust-embedded/riscv what do you think about updating our assembly functions to follow the same fashion as in cortex-m? @rust-embedded/cortex-m any advice on this?

@thejpster
Copy link

In general I like it when the risc-v ecosystem kinda looks and feels like the cortex-m ecosystem, as it makes it easier to move between the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants