Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for 0.2.0 release #52

Closed
2 of 4 tasks
Manishearth opened this issue Dec 30, 2019 · 12 comments · Fixed by #54
Closed
2 of 4 tasks

Tracking issue for 0.2.0 release #52

Manishearth opened this issue Dec 30, 2019 · 12 comments · Fixed by #54

Comments

@Manishearth
Copy link
Member

Manishearth commented Dec 30, 2019

This is being developed on the next branch Update: the next branch has been merged into `master.

We should release 0.2.0 or perhaps 1.0.0 and make cargo-fuzz start using it!

Prerequisites:

@fitzgen
Copy link
Member

fitzgen commented Dec 30, 2019

Perhaps name the crate libfuzzer since it's more high level than than just sys stuff?

+1 on teasing apart the bit that builds and links libfuzzer from the integration with arbitrary and the macro that users actually use and all that.

@fitzgen
Copy link
Member

fitzgen commented Jan 10, 2020

Perhaps name the crate libfuzzer since it's more high level than than just sys stuff?

@Manishearth since we don't want to mess with master because of all the existing git dependencies, what if we do this:

  • Create a new rust-fuzz/libfuzzer-rs repo that is a fork (but not in the github sense) of this repo
  • Archive this repo with a README noice to use that new repo instead
    • And now all the existing git deps will continue to work forever
  • And then we actually continue dev on the new repo:
    • transfer relevant issues over
    • split sys and highlevel utils crates (but still in same repo/workspace)
    • etc

Thoughts?

@Manishearth
Copy link
Member Author

Manishearth commented Jan 11, 2020 via email

@Manishearth
Copy link
Member Author

Manishearth commented Jan 11, 2020 via email

@fitzgen
Copy link
Member

fitzgen commented Jan 13, 2020

I don't have admin access, so I can't do this shuffling. Happy to do it if you or someone else gives me that access! :)

@Manishearth
Copy link
Member Author

Made you an org admin, go nuts!

@fitzgen
Copy link
Member

fitzgen commented Jan 14, 2020

Huh... I still don't have access to the admin panel or anything. Can't find an email from github that I need to accept or anything like that either...

@Manishearth
Copy link
Member Author

I'd upgraded you to org admin, but maybe that didn't go through. Try now?

@fitzgen
Copy link
Member

fitzgen commented Jan 14, 2020

Ok, now I have it! Thanks!

@fitzgen
Copy link
Member

fitzgen commented Jan 14, 2020

Ok, this repo is now rust-fuzz/libfuzzer!

We also have an archived rust-fuzz/libfuzzer-sys repo so that the old git deps will continue to work and we don't break anyone's existing installs.

@fitzgen
Copy link
Member

fitzgen commented Jan 14, 2020

I also merged the next branch into master on this new repo, btw.

@fitzgen
Copy link
Member

fitzgen commented Jan 14, 2020

Ok I made an initial attempt at splitting this crate apart into libfuzzer and libfuzzer-sys. The libfuzzer build, and its interaction with sanitizers and code coverage, is so fragile that I immediately ran into linker errors despite only doing code motion between crates. I don't have the energy for that today.

https://github.com/fitzgen/libfuzzer/tree/split-libfuzzer-and-libfuzzer-sys if anyone else wants to take a look at it.

But I think I'm going to skip it for the 0.2.0 release of libfuzzer-sys.

fitzgen added a commit to fitzgen/libfuzzer that referenced this issue Jan 14, 2020
fitzgen added a commit to fitzgen/libfuzzer that referenced this issue Jan 14, 2020
fitzgen added a commit to fitzgen/libfuzzer that referenced this issue Jan 14, 2020
fitzgen added a commit to fitzgen/libfuzzer that referenced this issue Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants