Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable signing without private key #291

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Enable signing without private key #291

merged 6 commits into from
Sep 24, 2024

Conversation

djc
Copy link
Member

@djc djc commented Sep 24, 2024

Takes #288 and addresses the comments.

Fixes #282.

@djc djc force-pushed the cert-from-pk-only branch 2 times, most recently from bf2932a to 698eb9f Compare September 24, 2024 10:30
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, thanks for picking this up.

rcgen/src/error.rs Outdated Show resolved Hide resolved
rcgen/src/key_pair.rs Outdated Show resolved Hide resolved
rcgen/src/key_pair.rs Outdated Show resolved Hide resolved
rcgen/src/key_pair.rs Outdated Show resolved Hide resolved
@djc
Copy link
Member Author

djc commented Sep 24, 2024

Since this merely addressed the comments from #288 which already got @est31's approval, going to merge this. @est31 holler if you have any feedback!

@djc djc enabled auto-merge September 24, 2024 20:23
@djc djc added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 2faf2e1 Sep 24, 2024
28 checks passed
@djc djc deleted the cert-from-pk-only branch September 24, 2024 20:45
@kwantam
Copy link
Contributor

kwantam commented Sep 25, 2024

Thanks for doing this and apologies that I have been buried!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSR with PublicKey only
3 participants