You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
prompt$ make
mkdir bin
cp scripts/keyd-application-mapper bin/
sed -e 's#@PREFIX@#/usr/local#' keyd.service.in > keyd.service
sed -e 's#@PREFIX@#/usr/local#' src/vkbd/usb-gadget.service.in > src/vkbd/usb-gadget.service
cc -DVERSION=\"v2.5.0\ \(f33dca8\)\" -I/usr/local/include -L/usr/local/lib -Wall -Wextra -Wno-unused -std=c11 -DSOCKET_PATH=\"/var/run/keyd.socket\" -DCONFIG_DIR=\"/etc/keyd\" -DDATA_DIR=\"/usr/local/share/keyd\" -D_FORTIFY_SOURCE=2 -D_DEFAULT_SOURCE -Werror=format-security -O3 src/*.c src/vkbd/uinput.c -lpthread -o bin/keyd
src/daemon.c: In function ‘add_listener’:
src/daemon.c:84:33: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
84 | write(con, layer->type == LT_LAYOUT ? "/" : "+", 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/daemon.c:85:33: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
85 | write(con, layer->name, strlen(layer->name));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/daemon.c:86:33: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
86 | write(con, "\n", 1);
| ^~~~~~~~~~~~~~~~~~~
prompt$
Most places in the code use xwrite(). Is there a reason to use write() in these three places in src/daemon.c? I'd be happy to submit a PR to switch them to xwrite() to make the build warning go away, if you want, but I thought I'd check here first.
The text was updated successfully, but these errors were encountered:
I built tag
v2.5.0
today and got this warning:Most places in the code use
xwrite()
. Is there a reason to usewrite()
in these three places insrc/daemon.c
? I'd be happy to submit a PR to switch them toxwrite()
to make the build warning go away, if you want, but I thought I'd check here first.The text was updated successfully, but these errors were encountered: