Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC: Remove emotion and move to CSS #127

Open
rzkhosroshahi opened this issue Dec 20, 2023 · 0 comments · May be fixed by #128
Open

RC: Remove emotion and move to CSS #127

rzkhosroshahi opened this issue Dec 20, 2023 · 0 comments · May be fixed by #128
Labels
enhancement New feature or request

Comments

@rzkhosroshahi
Copy link
Owner

Emotion has lots of benefits, you can add custom and dynamic CSS and use JS power at the same time. but it comes with at least 25KB (gzip) bundle size and in our Zaman lib case there is no critical need to use emotion all styles which Zaman can easily rewrite by the CSS. so I decided to rewrite styles with CSS.

befits:

  • decrease bundle size

cost:

  • Zaman accepts accent colors and makes a theme for your date-picker with this change we gonna lose the feature of having two separate theme colors at the same time. it's not a big deal because it doesn't make sense to have this feature in product POV but anyway...
@rzkhosroshahi rzkhosroshahi added the enhancement New feature or request label Dec 20, 2023
@rzkhosroshahi rzkhosroshahi linked a pull request Dec 20, 2023 that will close this issue
@rzkhosroshahi rzkhosroshahi added this to the Remove emotions milestone Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant