Duplicated transactions when received Eth from another Safe and no ETHEREUM_TRACING_NODE_URL is set

[nick8319]

Describe the bug
When sending ETH from one Safe to another on Base Goerli Testnet chain, the transaction is indexed twice.

To Reproduce
Steps to reproduce the behavior:

1. Create 2 Safes in Base Goerli Testnet.
2. Send some ETH to Safe 1.
3. Send ETH from Safe 1 to Safe 2.
4. Safe 2 will have 2 "Received" transactions.
   Example: https://app.safe.global/transactions/history?safe=base-gor:0xD281290BF31aD660369A71E1aD6840a3048a0c17

Expected behavior
Safe 2 should have 1 "Received" transaction.

Environment (please complete the following information):

• Staging or production? Production
• Which chain? Base Goerli Testnet
• OS: MacOs
• Browser Firefox
• Version 4.21.3

Additional context
From what I noticed, this affects L2 chains which do not have ETHEREUM_TRACING_NODE_URL.

[Uxio0]

@JagoFigueroa are you able to reproduce this?

[JagoFigueroa]

Can confirm this duplication on chains like Base Goerli Testnet, Base Mainnet, Polygon and Celo.

Edited the message after some more testing

[Uxio0]

Problem is

safe-transaction-service/safe_transaction_service/history/indexers/safe_events_indexer.py

Line 283 in 65f1837

if args["value"] and not data: # Simulate ether transfer

and

safe-transaction-service/safe_transaction_service/history/indexers/safe_events_indexer.py

Line 326 in 65f1837

elif event_name == "SafeReceived": # Received ether

For Safe sending to another Safe we index the SafeReceived event and the MultisigTransaction of the other Safe. I don't see a clean solution for this, as there's no easy way to prove that a Ether received on the event is a result of the MultisigTransaction

[liliya-soroka]

The issue is actual for the zkSync Era mainnet network as well

[Uxio0]

The issue is actual for the zkSync Era mainnet network as well

This is expected to happen for every network