Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ability to upload local HD skins #114

Open
Babagi75 opened this issue Sep 11, 2024 · 6 comments
Open

[Feature] Add ability to upload local HD skins #114

Babagi75 opened this issue Sep 11, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@Babagi75
Copy link

Hi, im using minecraft 1.20.1 and have a problem when changing my skin. I change my 64x64 skin by "Drag & drop skin", it's working. but 128x128 isn't. I have similar skin mod (Essential mod & HD Skin mod), still not working after delete those mods.

@Babagi75 Babagi75 added the bug Something isn't working label Sep 11, 2024
@samolego
Copy link
Owner

Can you reproduce it with fabrictailor only? Please share some screenshots

@Babagi75
Copy link
Author

It's still not working. Drag & Drop skin not change anything, but i got this message by change HD skin from URL...

2024-09-11_16 47 12

mods : fabric-api, iris-1.7.2, sodium-fabric, fabric tailor.

@samolego
Copy link
Owner

Thanks! Seems like something changed in the update.

Currently I'm on holiday, so this might take some time before it's fixed.

@Babagi75
Copy link
Author

Okay, sorry for bothering your day, have a good day then.

@samolego
Copy link
Owner

Np, thanks!

@samolego samolego changed the title [BUG] HD Skin not load [Feature] Add ability to upload local HD skins Oct 16, 2024
@samolego samolego added enhancement New feature or request and removed bug Something isn't working labels Oct 16, 2024
@samolego
Copy link
Owner

Currently the system is set to upload the new image to mineskin (which only accepts vanilla styled skins). Current workaround is to upload skin somewhere then use the URL.

The upload feature could be improved to check the image dimensions.

samolego added a commit that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants