Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is 7.2-migration the stable branch for 7.2.1? #3072

Open
hackartisan opened this issue Feb 10, 2017 · 10 comments
Open

Is 7.2-migration the stable branch for 7.2.1? #3072

hackartisan opened this issue Feb 10, 2017 · 10 comments
Labels
Milestone

Comments

@hackartisan
Copy link
Contributor

Should it be renamed?

@hackartisan hackartisan added this to the 7.2.1 milestone Feb 10, 2017
@mjgiarlo
Copy link
Member

It could be. Do you have druthers, @jcoyne?

@jcoyne
Copy link
Contributor

jcoyne commented Feb 11, 2017

No horse in this race

@mjgiarlo
Copy link
Member

Go for it, @HackMasterA!

@hackartisan
Copy link
Contributor Author

@mjgiarlo rename it you mean? @Cam156 does this sound right to you?

@carolyncole
Copy link
Contributor

Did anything change in 7.x since we pinned 7.2-migration? If we rename it as is we still need to migrate into the 7.x branches at some point. My only concern with 7.2.1 is migration code is much more than a bug fix in semantic terms. If we were doing it right 7.4 would be sufia 7.3 with migration, but that is a lot of work and I do not have time until April or later to dive into that.

@mjgiarlo
Copy link
Member

@Cam156 I'm OK with deviating from semver in this case.

@HackMasterA yeah, a rename makes sense to me.

@hackartisan
Copy link
Contributor Author

@Cam156 I don't see a 7.x branch. There are a few commits on 7.1-stable but they all have red xes next to them...

@carolyncole
Copy link
Contributor

@HackMasterA I guess that 7.3 is still in the works so there is no 7.x branch. Sorry!

@hackartisan
Copy link
Contributor Author

Okay if it should be renamed it should probably be 7.2-development since it's not actually a stable branch; it's a branch adding migration features.

Also, I'm not sure what to do about those few post-release commits on 7.1-stable. How did they get merged if they have CI problems? Note I haven't actually looked at the travis output.

@mjgiarlo
Copy link
Member

Sounds good, @HackMasterA. I'm guessing those follow-on commits may have been cherry-picked over since they don't seem to have been part of any PRs. I believe they were all added to fix things breaking the build, so that is puzzling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants