Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: adjustable resolution #1

Open
AugmentedRealityCat opened this issue Mar 22, 2023 · 0 comments
Open

Feature Request: adjustable resolution #1

AugmentedRealityCat opened this issue Mar 22, 2023 · 0 comments

Comments

@AugmentedRealityCat
Copy link

AugmentedRealityCat commented Mar 22, 2023

First, thank you so much for making this wonderful extension and sharing it on Github. It's great and I'm sure it will be very popular.

Currently the code limits the resolution of the input image to 1024x1024 when it is used to create a 3d mesh or a 3d panorama.
This limits the mesh density that can be produced because it depends on the resolution of the image used to create it.

The feature I am requesting would make this 1024x1024 maximal resolution a variable and would expose it in the GUI so the user can adjust it.

I found two places where those values are hard-coded right now:
one in gradio_im_to_3d.py

image.thumbnail((1024,1024)) # limit the size of the input image

and one in gradio_pano_to_3d.py
image.thumbnail((1024,1024)) # limit the size of the image

A single variable defining both the X and the Y maximum resolutions at the same time is enough I suppose.
The default could be set to 1024.

I have already made tests by changing the hard-coded values to 2048 and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant