Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: in checkIfShouldMerge function #2

Open
tyuownu opened this issue Jun 29, 2017 · 0 comments
Open

BUG: in checkIfShouldMerge function #2

tyuownu opened this issue Jun 29, 2017 · 0 comments

Comments

@tyuownu
Copy link

tyuownu commented Jun 29, 2017

Dear all, I found a bug in checkIfShouldMerge function. See below:

mergedSensorReadings = S1.sensorReadings.concat(S2.sensorReadings);
fit = _SENSOR_READING_UTILS.linearRegerssion(mergedSensorReadings);

in the first line, we shoud delete the duplicate point the S1 and S2, to construct a new pointcloud, beacuse the duplicate will affect the fit in the next line linearRegerssion function.

I do not know the language that this repo used, so I can not help to fix it, lol. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant