Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motion capture issue (ds003846) #192

Closed
arnodelorme opened this issue Nov 28, 2023 · 13 comments
Closed

motion capture issue (ds003846) #192

arnodelorme opened this issue Nov 28, 2023 · 13 comments
Assignees

Comments

@arnodelorme
Copy link
Collaborator

arnodelorme commented Nov 28, 2023

Dataset ds003846 has motion data and cannot be imported. The issue is that the JSON file is not present.

https://nemar.org/dataexplorer/detail?dataset_id=ds003846

@arnodelorme
Copy link
Collaborator Author

Screen Shot 2023-11-28 at 2 10 13 PM

@sjeung
Copy link
Collaborator

sjeung commented Nov 29, 2023

Probably both the data set and import tool need to be brought up-to-date with the current motion spec.
I will submit the importer update before I go off on end of the year holiday.

@arnodelorme
Copy link
Collaborator Author

arnodelorme commented Nov 29, 2023 via email

@arnodelorme
Copy link
Collaborator Author

Hi @sjeung happy new year! Any update? Tx

@sjeung
Copy link
Collaborator

sjeung commented Feb 18, 2024

Hi @sjeung happy new year! Any update? Tx

Hello, happy new year to you, too! No matter which new year we follow I'm behind the schedule with this one. I will get to this now.

@arnodelorme
Copy link
Collaborator Author

arnodelorme commented Feb 18, 2024 via email

@sjeung
Copy link
Collaborator

sjeung commented Feb 18, 2024

Ok, this particular error seems to arise from nonadherence of the data set to the current motion spec. The .json accompanying motion.tsv should have a name matching the tsv file,

'sub-1_ses-TestEMS_task-PredError_tracksys-HTCVive_motion.json'
for
'sub-1_ses-TestEMS_task-PredError_tracksys-HTCVive_motion.tsv'

In the current data set, the metadata file is named
'sub-1_ses-TestEMS_task-PredError_motion.json'.

I will

  1. also check if a data set using up-to-date Motion BIDS can be imported using pop_importbids function, and submit needed changes to pop_importbids
  2. and ping the owner of the repo to bring the data set up-to-date

@sjeung
Copy link
Collaborator

sjeung commented Feb 18, 2024

I tested bids matlab tools with a different data set and opened this pull request. #199
Other than that it seems to work well

@lukasgehrke
Copy link

Hey @sjeung @arnodelorme, the dataset with accession number ds003846 has been updated on openneuro (https://openneuro.org/datasets/ds003846/versions/2.0.0). It should conform to the latest BIDS motion spec and pop_importbids works using @sjeung https://github.com/sjeung/bids-matlab-tools motion-bids branch as it needs to loop over multiple motion tracksys.

@arnodelorme
Copy link
Collaborator Author

arnodelorme commented Mar 21, 2024

OK, is it possible to issue a pull request on the main repo. The motion capture capabilities are beta, and so we can merge them in master. It is too complex for our research assistant to test a remote branch. CC @lukasgehrke @sjeung

@sjeung
Copy link
Collaborator

sjeung commented Mar 22, 2024

Hi Arno, I believe PR #199 deals with this. Thanks for merging!

@arnodelorme
Copy link
Collaborator Author

Ah OK, thanks. @asalazar4 would you mind to try this dataset again?

@arnodelorme arnodelorme self-assigned this Mar 26, 2024
@dungscout96 dungscout96 changed the title motion capture issue motion capture issue (ds003846) May 3, 2024
@dungscout96
Copy link
Contributor

Trying to import this dataset lead to a suggestion to the BIDS motion spec: bids-standard/bids-specification#1817
We also detected an issue of motion.json not containing the required SamplingFrequency field, which we are currently ignoring for now. We have updated error message for this dataset on NEMAR however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants