Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline toast notification #72

Merged
merged 3 commits into from
Apr 20, 2020
Merged

Offline toast notification #72

merged 3 commits into from
Apr 20, 2020

Conversation

ewen-lbh
Copy link
Member

Resolves #68.

@codecov
Copy link

codecov bot commented Apr 20, 2020 •
edited
Loading

Codecov Report

Merging #72 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #72      +/-   ##
=========================================
+ Coverage    3.40%   3.44%   +0.03%     
=========================================
  Files          62      60       -2     
  Lines        2201    2180      -21     
  Branches      607     605       -2     
=========================================
  Hits           75      75              
+ Misses       1770    1749      -21     
  Partials      356     356
Impacted Files Coverage Δ
layouts/bare.vue

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3c59de...f0443f0. Read the comment docs.

@ewen-lbh
Copy link
Member Author

I'm having issues with @vuejs/vue-test-utils -- seems like testing layouts is impossible. I'll add e2e tests for this with behave but the codecov diff hit target check will still fail. I guess I need to exclude "layouts" from the collected coverage, until I figure this out.

@ewen-lbh ewen-lbh merged commit d70a2ec into master Apr 20, 2020
@ewen-lbh ewen-lbh deleted the offline-toast-notification branch April 23, 2020 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toast notification when the browser goes offline
1 participant
@ewen-lbh