Report modal: different submitting states #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=========================================
- Coverage 3.55% 3.54% -0.01%
=========================================
Files 60 61 +1
Lines 2169 2174 +5
Branches 605 606 +1
=========================================
Hits 77 77
- Misses 1736 1741 +5
Partials 356 356
Continue to review full report at Codecov.
|
Your commits may have been pushed to |
|
@ifndev Oh yeah it makes sense now, will try to not do this again, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #78. Also make the submit button really submit the report.
An "error" state is still missing though.
NOTE: two commits of this branch are unrelated, I don't know how they ended up on this branch since I committed them before even creating the branch