Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate different submitting states on <ModalAddReport> #78

Open
ewen-lbh opened this issue Apr 26, 2020 · 0 comments · May be fixed by #79
Open

Indicate different submitting states on <ModalAddReport> #78

ewen-lbh opened this issue Apr 26, 2020 · 0 comments · May be fixed by #79
Assignees
@ewen-lbh
Labels
enhancement New feature or request lang:en Issues written in English

Comments

@ewen-lbh
Copy link
Member

Is your feature request related to a problem? Please describe.
The bug report/feature request modal does not actually make a request to the API, and it is not clear whether the report is currently submitting or is already submitted

Describe the solution you'd like
Add two states to the modal (with <ScreenSTATE> components), one for a report currently submitting, one for a report that is submitted:

  • submitting state: a spinner with a "submitting" text below it
  • submitted state: a thumbs-up image and a button to go to the reports (already sort-of implemented)
@ewen-lbh ewen-lbh added enhancement New feature or request lang:en Issues written in English labels Apr 26, 2020
@ewen-lbh ewen-lbh self-assigned this Apr 26, 2020
@ewen-lbh ewen-lbh linked a pull request Apr 26, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewen-lbh ewen-lbh

Labels
enhancement New feature or request lang:en Issues written in English
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report modal: different submitting states schoolsyst/webapp
1 participant
@ewen-lbh