Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 collection public show pg styling looks off #137

Open
6 of 7 tasks
ShanaLMoore opened this issue Sep 9, 2024 · 4 comments
Open
6 of 7 tasks

🐛 collection public show pg styling looks off #137

ShanaLMoore opened this issue Sep 9, 2024 · 4 comments
Assignees
Labels
bug something isn't working High Priority

Comments

@ShanaLMoore
Copy link
Contributor

ShanaLMoore commented Sep 9, 2024

Summary

the collection show page looks unusable in its current state, due to styling issues. Reported by Rob on pals STAGING.

see THREAD for more details

credentials are in 1password

Acceptance Criteria

  • Collection show page matches production functionality/styling
    • fix pagination button. it currently displays vertically
    • fix display of diff options.
      • list
      • gallery
      • masonry
      • show

Image

Image

Screenshots or Video (staging vs prod)

https://share.zight.com/5zuo1yln
https://share.zight.com/GGuekNwj
https://share.zight.com/p9uo7KmY

Testing Instructions

go into admin dashboard > collections
click on the one you want. it should open the collection show page
click on the link "public view of collection" to see the user's perspective

Notes

PRODUCTION

LIST

Image

GALLERY

Image

MASONRY

Image

SHOW (view option)

Image

@ShanaLMoore ShanaLMoore added High Priority bug something isn't working labels Sep 9, 2024
@ShanaLMoore ShanaLMoore changed the title 🐛 collection show styling looks off 🐛 collection show page - gallery view styling looks off Sep 10, 2024
@ShanaLMoore ShanaLMoore changed the title 🐛 collection show page - gallery view styling looks off 🐛 collection public show pg styling looks off Sep 10, 2024
@ShanaLMoore
Copy link
Contributor Author

ShanaLMoore commented Sep 11, 2024

cc @AKFosterDev Do you think you'd be able to tackle this ticket? Your UI skills would be really helpful here. I can help you spin up the project if needed.

@AKFosterDev
Copy link

@ShanaLMoore - Yes, I'd be happy to pick this up. I can look into it later today. Will reach out if I need help spinning up.

@AKFosterDev AKFosterDev self-assigned this Sep 11, 2024
@AKFosterDev
Copy link

Ticket Status Update

It appears that the styling issues on this page are coming from Hyku. Currently comparing Adventist Knapsack collection show page to confirm.

@AKFosterDev
Copy link

Hyku PR #2345
Pals PR - WIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working High Priority
Projects
None yet
Development

No branches or pull requests

2 participants