Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload directory of images #293

Closed
wants to merge 1 commit into from
Closed

Upload directory of images #293

wants to merge 1 commit into from

Conversation

2knal
Copy link
Contributor

@2knal 2knal commented Feb 23, 2020

Description

We can now add directory containing the images we want to upload.
They'll be added to the server's uploads/<directory_name> directory.

Fixes #272

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

On the forked repo.

Also, include screenshots of app for the verification and reviewing purpose.

1
2
3

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@2knal
Copy link
Contributor Author

2knal commented Feb 25, 2020

@Tushar19varshney, right now I've just displayed the directory name in front of the image. Can you please suggest a better UI representation for the same?

@Tushar19varshney
Copy link
Contributor

@Tushar19varshney, right now I've just displayed the directory name in front of the image. Can you please suggest a better UI representation for the same?

Current UI is sufficient for implementing this feature.
@2knal Why that image link thing coming when you are uploading a directory as a directory can contain many images ??

@Tushar19varshney
Copy link
Contributor

Also, rebase your PR!

@Tushar19varshney Tushar19varshney added the reviewed Pull request reviewed label Feb 28, 2020
@2knal
Copy link
Contributor Author

2knal commented Mar 1, 2020

Current UI is sufficient for implementing this feature.
@2knal Why that image link thing coming when you are uploading a directory as a directory can contain many images ??

Sorry, can you please elaborate, I didn't understand what you meant by that. 🙈

Upload directory of images
cf4720b 
We can now upload directory containing the images we want to upload.
They'll be added to the server's `uploads/` directory.

Closes scorelab#272
@ThatUdeshUK
Copy link
Collaborator

Closing because of inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tushar19varshney Tushar19varshney Awaiting requested review from Tushar19varshney

Assignees
No one assigned
Labels
reviewed Pull request reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directory upload
3 participants
@2knal @Tushar19varshney @ThatUdeshUK