Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support HTML content!!! but bundle size up by 60kb #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support HTML content!!! but bundle size up by 60kb #132

wants to merge 1 commit into from

Conversation

bodobraegger
Copy link
Collaborator

  • to undo, simply revert this commit!
  • quite a chunky new dependency, with it's newest version not supported by other deps.

Do we need to support raw html?

  • If anything needs to be added that is not supported in markdown, this would be the easiest solution.
  • Reverting this change should be easy enough, but if content is written in HTML it will have to be removed from the backend manually of course. Releasing to the public would require careful consideration to include HTML parsing support in our interface or not.

I would be glad if someone could weigh in on this decision!

@bodobraegger
support HTML content!!! but bundle size up by 60kb
4d3631d 
 -  to undo, simply revert this commit!
@bodobraegger bodobraegger added code Issue related to coding changes dependencies Issue is related with other issues clarification Clarification labels Sep 6, 2023
@bodobraegger bodobraegger self-assigned this Sep 6, 2023
jimmylevell
jimmylevell reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@jimmylevell jimmylevell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

differed until we implemented v1.1. Currently no use case to implement this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmylevell jimmylevell jimmylevell left review comments

@aladwani aladwani Awaiting requested review from aladwani

Assignees

@bodobraegger bodobraegger

Labels
clarification Clarification code Issue related to coding changes dependencies Issue is related with other issues v1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bodobraegger @jimmylevell