Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing v1.0.0 #15

Open
safwank opened this issue Jun 5, 2020 · 2 comments
Open

Publishing v1.0.0 #15

safwank opened this issue Jun 5, 2020 · 2 comments

Comments

@safwank
Copy link
Contributor

safwank commented Jun 5, 2020

Hi guys,

First of all, thanks heaps for building this library!

I'm wondering if you're planning to publish v1.0.0 to hex.pm anytime soon.

Also, I've noticed that the POST URL generated by the tracker is incorrect as this spec indicates:

assert String.contains?(url, "http://localhost:8000/com.snowplowanalytics.snowplow?tp2")
. Shouldn't it be /tp2 instead of ?tp2?

@goodhamgupta
Copy link
Member

Hi @safwank,

Glad you found this library useful and thank you for your feedback! You are right, the url should be /tp2 instead of ?tp2 as mentioned in the snowplow documentation here and available in the ruby tracker here.

If you are up for it, we would be happy to accept a fix this issue! 👍

@safwank
Copy link
Contributor Author

safwank commented Jun 5, 2020

PR here: #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants