feat: official runner #599
Conversation
scripts/ci/Dockerfile
Outdated
|
|
||
| RUN sudo ./bin/installdependencies.sh |
There was a problem hiding this comment.
Oh, we still need to run this, it's not already run on the base image? Interesting.
scripts/ci/Dockerfile
Outdated
|
|
||
| # GitHub action runner scripts (config.sh and run.sh) are not allowed to be run as root | ||
| USER docker | ||
| RUN sudo chown runner:runner start.sh && chmod +x start.sh |
There was a problem hiding this comment.
Why does start.sh need to be owned by the runner user?
There was a problem hiding this comment.
the default user is runner in the base image
There was a problem hiding this comment.
OK? You can run files that you don't own as far as I can tell?
There was a problem hiding this comment.
Thanks for the write-up. Could you also please mention where you need to run these commands? Presumably not on your laptop?
You can add some words to explain that this is only for people at Scroll, and that if you work on an open source fork, this doesn't apply to you. Thanks.
There was a problem hiding this comment.
@lightsing could you address this comments?
No description provided.